Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate all icon URLs to blizzard links #349

Open
1 of 11 tasks
Nakroma opened this issue Feb 21, 2020 · 0 comments
Open
1 of 11 tasks

Migrate all icon URLs to blizzard links #349

Nakroma opened this issue Feb 21, 2020 · 0 comments
Labels
Game: WoW Classic Issues that concern the WoW Classic subsite. good first issue Easy issues for newcomers to the project. Scope: API Type: Enhancement

Comments

@Nakroma
Copy link
Member

Nakroma commented Feb 21, 2020

I'm submitting a...

  • Bug report
  • Feature request
  • Documentation issue or request

Current behavior

Currently the raw icon name is used in the item database and the wowhead link is added manually.


Expected behavior

This needs to be migrated so that the item database uses the official blizzard link by default (see here: https://github.com/nexus-devs/wow-classic-items). Might also make sense to keep the icon prop and define an imgUrl property for the actual url.


Minimal reproduction of the problem


Environment

Browser:

  • Chrome (desktop) version:
  • Chrome (Android) version:
  • Chrome (iOS) version:
  • Firefox version:
  • Safari (desktop) version:
  • Safari (iOS) version:
  • IE version:
  • Edge version:

For development issues:

  • Node version:
  • Operating System:

Additional Description

@Nakroma Nakroma added Type: Enhancement Scope: API good first issue Easy issues for newcomers to the project. Game: WoW Classic Issues that concern the WoW Classic subsite. labels Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Game: WoW Classic Issues that concern the WoW Classic subsite. good first issue Easy issues for newcomers to the project. Scope: API Type: Enhancement
Projects
None yet
Development

No branches or pull requests

1 participant