Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Urlencode CI token #370

Open
1 of 11 tasks
Nakroma opened this issue May 5, 2020 · 0 comments
Open
1 of 11 tasks

Urlencode CI token #370

Nakroma opened this issue May 5, 2020 · 0 comments
Labels
good first issue Easy issues for newcomers to the project. Scope: CI Continuous Integration Severity3: Minor The defect affects minor functionality or non-critical data. It has an easy workaround. Type: Bug

Comments

@Nakroma
Copy link
Member

Nakroma commented May 5, 2020

I'm submitting a...

  • Bug report
  • Feature request
  • Documentation issue or request

Current behavior

Currently the CI token is not escaped, i.e. chars like # and @ need to be manually urlencoded https://github.com/nexus-devs/NexusHub/blob/development/ci/git/push-staging.sh#L20


Expected behavior

Automatically urlencode the NEXUS_CI_TOKEN string


Minimal reproduction of the problem


Environment

Browser:

  • Chrome (desktop) version:
  • Chrome (Android) version:
  • Chrome (iOS) version:
  • Firefox version:
  • Safari (desktop) version:
  • Safari (iOS) version:
  • IE version:
  • Edge version:

For development issues:

  • Node version:
  • Operating System:

Additional Description
@Nakroma Nakroma added Type: Bug Scope: CI Continuous Integration good first issue Easy issues for newcomers to the project. Severity3: Minor The defect affects minor functionality or non-critical data. It has an easy workaround. labels May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Easy issues for newcomers to the project. Scope: CI Continuous Integration Severity3: Minor The defect affects minor functionality or non-critical data. It has an easy workaround. Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Nakroma