Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In some cases RGI will not produce all files expected for mving for publishing #376

Closed
jfy133 opened this issue May 15, 2024 · 5 comments · Fixed by #377
Closed

In some cases RGI will not produce all files expected for mving for publishing #376

jfy133 opened this issue May 15, 2024 · 5 comments · Fixed by #377
Labels
bug Something isn't working

Comments

@jfy133
Copy link
Member

jfy133 commented May 15, 2024

Description of the bug

https://nfcore.slack.com/archives/C02K5GX2W93/p1715619477736569

Just need to make ,mv. commands only executed if present

Command used and terminal output

No response

Relevant files

No response

System information

No response

@jfy133 jfy133 added the bug Something isn't working label May 15, 2024
@jfy133
Copy link
Member Author

jfy133 commented May 15, 2024

Module in, juyst need to update

@jfy133 jfy133 mentioned this issue May 15, 2024
10 tasks
@amizeranschi
Copy link

Hey @jfy133

Thanks a lot for following up on this issue. I've tested the following replacement for the mv command and it got RGI working fine for me:

for FILE in *.xml *.fsa *.{nhr,nin,nsq} *.draft *.potentialGenes *{variant,rrna,protein,predictedGenes,overexpression,homolog}.json; do [[ -e \$FILE ]] && mv \$FILE temp/; done

@jfy133
Copy link
Member Author

jfy133 commented May 16, 2024

Oh nice @amizeranschi ! That's much better than my solution...

I updated the module over at nf-core/modules, so you get credit, could you make a PR replacing my horrible copypasta over there and ping me for review? Then we can update the pipeline :)

@amizeranschi
Copy link

This should now be fixed by nf-core/modules#5614

@jfy133 jfy133 reopened this May 16, 2024
@jfy133
Copy link
Member Author

jfy133 commented May 16, 2024

Reopened until update is in pipeline :)

@jfy133 jfy133 closed this as completed May 22, 2024
@jasmezz jasmezz mentioned this issue Jul 29, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants