Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from paths-filter #3808

Closed
2 tasks done
edmundmiller opened this issue Sep 4, 2023 · 4 comments
Closed
2 tasks done

Move from paths-filter #3808

edmundmiller opened this issue Sep 4, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@edmundmiller
Copy link
Contributor

Have you checked the docs?

Description of the bug

It's served us well, but we're hitting API limits.

Maybe we're able to pass it an API key through a secret?

Example in #3807

Command used and terminal output

No response

Relevant files

No response

System information

No response

@edmundmiller edmundmiller added the bug Something isn't working label Sep 4, 2023
@edmundmiller
Copy link
Contributor Author

dorny/paths-filter#108
dorny/paths-filter#73

Hmm I don't think it's paths-filter, I think we're hitting it somewhere else, and I think it's just the first thing to hit the API...

@edmundmiller edmundmiller added hackathon2023 Topic for the hackathon of March 2023 bug Something isn't working and removed bug Something isn't working hackathon2023 Topic for the hackathon of March 2023 labels Nov 21, 2023
@frouioui
Copy link

frouioui commented Feb 14, 2024

Hello @edmundmiller, using dorny/paths-filter#133 I have been to alleviate the API rate limit issues we were hitting on https://github.com/vitessio/vitess.

Here is the PR that uses dorny/paths-filter#133 in vitess: vitessio/vitess#10106

cc @mirpedrol

@edmundmiller
Copy link
Contributor Author

@frouioui Hey thanks for reaching out! I think @mirpedrol solved it in #4202

@dorny
Copy link

dorny commented Feb 15, 2024

FYI: the @frouioui fix has been merged in dorny/paths-filter#133
and included in v3.0.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: No status
Development

No branches or pull requests

3 participants