Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks for QC filtering #46

Closed
fasterius opened this issue Jun 12, 2023 · 2 comments
Closed

Add checks for QC filtering #46

fasterius opened this issue Jun 12, 2023 · 2 comments
Labels
enhancement Improvement for existing functionality

Comments

@fasterius
Copy link
Collaborator

Description of feature

Currently, the filtering of e.g. minimum counts or genes in the quality control report has no related checks to see if there are any spots lefter the filtering. Filtering itself will work just fine, but will produce non-informative errors downstream, which should be improved. The check should output an informative message about (1) what filtering step raised the problem, (2) what the relevant parameter was set to (either default or user-specified) and (3) that the user should re-run with a lowered threshold.

I'm not sure whether this type of check should stop the pipeline or not. Such errors currently do yield errors that stop the pipeline, but we could also re-work the QC report in some fashion to still be able to output something - this could possibly be a useful functionality to have in regards to using e.g. checkatlas or multiqc for aggregating multiple reports as discussed in #40.

@fasterius fasterius added the enhancement Improvement for existing functionality label Jun 12, 2023
@grst
Copy link
Member

grst commented Jun 12, 2023

I ran into this as well. The main problem was that the in_tissue column was parsed with the wrong dtype, leading to all spots being filtered out, no matter the threshold.

This is fixed by this commit: 8d1e5fa

Regardless, I agree that it would be nice to catch the case when no spots are left.

@fasterius
Copy link
Collaborator Author

This is currently in the dev branch of the pipeline, implemented in such a way that it won't stop the pipeline but rather continue on without filtering as well as giving a notice to the user in the relevant report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement for existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants