Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiQC 1.21 doesn't support genomic_dna section #84

Closed
Alan-pad opened this issue Jul 16, 2024 · 1 comment · Fixed by #85
Closed

MultiQC 1.21 doesn't support genomic_dna section #84

Alan-pad opened this issue Jul 16, 2024 · 1 comment · Fixed by #85
Labels
bug Something isn't working

Comments

@Alan-pad
Copy link

Description of the bug

When launching this workflow :

nextflow run nf-core/spatialvi -r dev \
   -profile docker \
   --input /shared/samplesheet_spaceranger.csv \
   --spaceranger_probeset /shared/Visium_Human_Transcriptome_Probe_Set_v1.0_GRCh38-2020-A.csv \
   --spaceranger_reference /shared/homo_sapiens_chr22_reference.tar.gz \
   --qc_min_counts 5 \
   --qc_min_genes 3 \
   --outdir /shared/test_output

I had this error at the MultiQC step :

    /// MultiQC 🔍 | v1.21

  |           multiqc | MultiQC Version v1.23 now available!
  |           multiqc | Search path : /home/alanl/work/c8/6af00af8c6888f021e0e867cbe27d2
  |         searching | ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 61/61
  |    custom_content | nf-core-spatialvi-summary: Found 1 sample (html)
  |    custom_content | nf-core-spatialvi-methods-description: Found 1 sample (html)
  |            fastqc | Found 2 reports
  ╭────────────── Oops! The 'spaceranger' MultiQC module broke... ───────────────╮
  │ Please copy this log and report it at                                        │
  │ https://github.com/MultiQC/MultiQC/issues                                    │
  │ Please attach a file that triggers the error. The last file found was:       │
  │ 52/web_summary.html                                                          │
  │                                                                              │
  │ Traceback (most recent call last):                                           │
  │   File "/usr/local/lib/python3.11/site-packages/multiqc/multiqc.py", line 75 │
  │     output = mod()                                                           │
  │              ^^^^^                                                           │
  │   File "/usr/local/lib/python3.11/site-packages/multiqc/modules/spaceranger/ │
  │     n["count"] = self.parse_count_html()                                     │
  │                  ^^^^^^^^^^^^^^^^^^^^^^^                                     │
  │   File "/usr/local/lib/python3.11/site-packages/multiqc/modules/spaceranger/ │
  │     description=self.spacerangercount_plots_conf["genomic_dna"]["description │
  │                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^              │
  │ KeyError: 'genomic_dna'                                                      │
  │                                                                              │
  ╰──────────────────────────────────────────────────────────────────────────────╯
  |           multiqc | Report      : multiqc_report.html
  |           multiqc | Data        : multiqc_data
  |           multiqc | Plots       : multiqc_plots
  |           multiqc | MultiQC complete

Looking up issues on Github I found this was related to this issue (MultiQC/MultiQC#2428) that was fixed in 1.22 (https://github.com/MultiQC/MultiQC/releases/tag/v1.22)

I then forked spatialvi and updated the multiqc version on my fork and it worked : Alan-pad@10776c3

Command used and terminal output

nextflow run nf-core/spatialvi -r dev \
   -profile docker \
   --input /shared/samplesheet_spaceranger.csv \
   --spaceranger_probeset /shared/Visium_Human_Transcriptome_Probe_Set_v1.0_GRCh38-2020-A.csv \
   --spaceranger_reference /shared/homo_sapiens_chr22_reference.tar.gz \
   --qc_min_counts 5 \
   --qc_min_genes 3 \
   --outdir /shared/test_output

    /// MultiQC 🔍 | v1.21

  |           multiqc | MultiQC Version v1.23 now available!
  |           multiqc | Search path : /home/alanl/work/c8/6af00af8c6888f021e0e867cbe27d2
  |         searching | ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 61/61
  |    custom_content | nf-core-spatialvi-summary: Found 1 sample (html)
  |    custom_content | nf-core-spatialvi-methods-description: Found 1 sample (html)
  |            fastqc | Found 2 reports
  ╭────────────── Oops! The 'spaceranger' MultiQC module broke... ───────────────╮
  │ Please copy this log and report it at                                        │
  │ https://github.com/MultiQC/MultiQC/issues                                    │
  │ Please attach a file that triggers the error. The last file found was:       │
  │ 52/web_summary.html                                                          │
  │                                                                              │
  │ Traceback (most recent call last):                                           │
  │   File "/usr/local/lib/python3.11/site-packages/multiqc/multiqc.py", line 75 │
  │     output = mod()                                                           │
  │              ^^^^^                                                           │
  │   File "/usr/local/lib/python3.11/site-packages/multiqc/modules/spaceranger/ │
  │     n["count"] = self.parse_count_html()                                     │
  │                  ^^^^^^^^^^^^^^^^^^^^^^^                                     │
  │   File "/usr/local/lib/python3.11/site-packages/multiqc/modules/spaceranger/ │
  │     description=self.spacerangercount_plots_conf["genomic_dna"]["description │
  │                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^              │
  │ KeyError: 'genomic_dna'                                                      │
  │                                                                              │
  ╰──────────────────────────────────────────────────────────────────────────────╯
  |           multiqc | Report      : multiqc_report.html
  |           multiqc | Data        : multiqc_data
  |           multiqc | Plots       : multiqc_plots
  |           multiqc | MultiQC complete

Relevant files

No response

System information

No response

@Alan-pad Alan-pad added the bug Something isn't working label Jul 16, 2024
@fasterius fasterius linked a pull request Aug 16, 2024 that will close this issue
11 tasks
@fasterius
Copy link
Collaborator

Thanks for the reminder! The MultiQC module wasn't updated the last time I was working on this, but now it is. This should now work on the dev branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants