Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Cannot add second assay to my ARC #281

Closed
HLWeil opened this issue Oct 7, 2024 · 4 comments
Closed

[BUG] Cannot add second assay to my ARC #281

HLWeil opened this issue Oct 7, 2024 · 4 comments
Assignees
Labels
Critical Type: Bug Something is not working, and it is confirmed by maintainers to be a bug.

Comments

@HLWeil
Copy link
Member

HLWeil commented Oct 7, 2024

OS and framework information (please complete the following information):

  • OS: Windows 11
  • ARCitect version 0.0.46

Describe the bug

Arcitect_Assay_Bug

  • The first Assay in the ARC contains a DataMap which works just fine
  • Adding a second study is possible
@github-actions github-actions bot added the Status: Needs Triage This item is up for investigation. label Oct 7, 2024
@HLWeil HLWeil changed the title [BUG] plac [BUG] Cannot add second assay to my ARC Oct 7, 2024
@HLWeil
Copy link
Member Author

HLWeil commented Oct 8, 2024

It's related to Datamap, reproducible steps:

  1. Create new ARC
  2. Add Assay
  3. Add Datamap to Assay
  4. Add 1 Row to Datamap and fill out any cell
  5. Try to add second assay
  6. Nothing happens

@JonasLukasczyk
Copy link
Collaborator

Is this then not an ARControl issue?

@JonasLukasczyk JonasLukasczyk added Type: Bug Something is not working, and it is confirmed by maintainers to be a bug. and removed Status: Needs Triage This item is up for investigation. labels Oct 8, 2024
@HLWeil
Copy link
Member Author

HLWeil commented Oct 8, 2024

Yesn't. The issue is, ARCtrl writes the datamap as its own isa.datamap.xlsx per default. This is fine by specification and was the initial default.
Now the problem is, that by specification, it is also fine to write the datamap as a sheet directly in the assay file. Swate goes this route, making everything function fine when having a single assay, which is written by Swate also in ARCitect.
When you add a second assay, ARCitect apparently also get's handed the Datamap write contract from ARCtrl. This it can't fulfill because the implementation is missing.

My route now: related to nfdi4plants/ARCtrl#407, I'll add at a toggle between writing the file or the sheet. ARCitect can then just choose to always write the sheet.

@JonasLukasczyk
Copy link
Collaborator

Fixed in #285

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical Type: Bug Something is not working, and it is confirmed by maintainers to be a bug.
Projects
Status: Done
Development

No branches or pull requests

2 participants