Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Different arguments of ArcAssay.create() in javascript and F# #430

Closed
xiaoranzhou opened this issue Sep 4, 2024 · 2 comments
Closed
Labels
documentation Improvements or additions to documentation JavaScript Native use from JavaScript .NET Native use from .NET Type: Bug Something is not working, and it is confirmed by maintainers to be a bug.

Comments

@xiaoranzhou
Copy link
Member

Found undocumented code? Please link it here
A link to the code in the repository.

Found a problem with existing documentation?
I have fixed my code, this issue is just a FYI.
If you think this is helpful, I can also contribute to the ARCtrl DOCs.

There is an additional "datamap" arugument in the JavaScript arctrl.ArcAssay.create() comparing to the F# equivalent.

For example:
F#
const myAssay = arctrl.ArcAssay.create("myassay", myexperimenttype, myexperimenttech, myexperimentplatform, [table], [person], [comments]);
is equal to
Javascript
const myAssay = arctrl.ArcAssay.create("myassay", myexperimenttype, myexperimenttech, myexperimentplatform, [table], void 0,[person], [comments]);

**

@xiaoranzhou xiaoranzhou added the documentation Improvements or additions to documentation label Sep 4, 2024
@github-actions github-actions bot added the Status: Needs Triage This item is up for investigation. label Sep 4, 2024
@HLWeil
Copy link
Member

HLWeil commented Sep 5, 2024

Hey @xiaoranzhou, thanks for your input. This is a bit surprising, as the member should exist in F# too:

static member create (identifier: string, ?measurementType : OntologyAnnotation, ?technologyType : OntologyAnnotation, ?technologyPlatform : OntologyAnnotation, ?tables: ResizeArray<ArcTable>, ?datamap : DataMap, ?performers : ResizeArray<Person>, ?comments : ResizeArray<Comment>) =

Which package versions are you using?

@HLWeil HLWeil added Type: Bug Something is not working, and it is confirmed by maintainers to be a bug. JavaScript Native use from JavaScript .NET Native use from .NET and removed Status: Needs Triage This item is up for investigation. labels Sep 6, 2024
@xiaoranzhou
Copy link
Member Author

I am using the 2.0.1 I think. Then never mind. I can add this part to the tutorial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation JavaScript Native use from JavaScript .NET Native use from .NET Type: Bug Something is not working, and it is confirmed by maintainers to be a bug.
Projects
Status: Done
Development

No branches or pull requests

2 participants