-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More detail instructions #76
Comments
Not sure if this is necessary, that section is pretty clear - The first line mentions the need to download sketch tool
And right below the link to the repository showing the example implementation of gulp-iconfont alongside with Sketch. |
You can explicitly add the need to download the sketch tool if you think it makes things clearer.
? Also, i'm wondering if the gulp-iconfont readme is the right place to explain how to use sketch with it. Maybe we should just link to the readme of those repos and keep a single source of truth. |
@nfroidure, that is a good point. In my opinion, when someone comes to this repo and needs to see the example of the gulp task in action, they would only need Sketch tool, Sketch is optional. I am proposing something like the following for the instruction: Run the Example
|
Those instructions are incorrect. The other repository, maintained by cognitom, has other dependencies as well. Sketch Tools (on Bohemian Coding's website), gulp-sketch, and this repository (gulp-iconfont). Edit: Perhaps calling it a "sample" repo is also adding to the confusion...hmm.. |
Since i'm not using Sketch, i think i cannot help. Maybe @cognitom is the best referrer to answer to those questions. cc @victordarras any advice? |
Hi, guys! Add last (bold one):
Remove them:
|
Hm, yeah pointing to another repo as an example is a bit confusing. And since this READMe section is supposed to just be about SVG settings, maybe just be a bit more descriptive and show a snippet of code instead. Something like:
|
Is this still an issue for you? Would some of you build a PR on top of this? |
First of all, thank you for doing this. It is awesome work.
When first started I quickly jumped down to the instructions section for Sketch: https://github.com/nfroidure/gulp-iconfont#sketch
Downloaded the zip file and 💥 it didn't work.
It took me awhile to realize that I need Sketch tool installed, which is not mentioned there. Would you mind if I open a PR for that? Thank you again.
The text was updated successfully, but these errors were encountered: