Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taler-sync #85

Closed
augustebaum opened this issue Oct 30, 2023 · 4 comments · Fixed by #99
Closed

taler-sync #85

augustebaum opened this issue Oct 30, 2023 · 4 comments · Fixed by #99
Labels
NGI0 Review Funded through NGI Zero Review package Create a Nix package

Comments

@augustebaum
Copy link
Contributor

Source code

Related to #5.

Provides multiple packages.

@augustebaum augustebaum added package Create a Nix package NGI0 Review Funded through NGI Zero Review labels Oct 30, 2023
@augustebaum
Copy link
Contributor Author

I've started working on a derivation at this branch: https://github.com/ngi-nix/ngipkgs/tree/sync.git.
However it currently fails to build with this somewhat obscure error:

make  all-recursive
make[1]: Entering directory '/tmp/tmp.BkGP6nYoG4/1kk506cznml2m4vwsdis56l0wwdclcw5-source'
Making all in .
make[2]: Entering directory '/tmp/tmp.BkGP6nYoG4/1kk506cznml2m4vwsdis56l0wwdclcw5-source'
make[2]: Leaving directory '/tmp/tmp.BkGP6nYoG4/1kk506cznml2m4vwsdis56l0wwdclcw5-source'
Making all in src
make[2]: Entering directory '/tmp/tmp.BkGP6nYoG4/1kk506cznml2m4vwsdis56l0wwdclcw5-source/src'
Making all in include
make[3]: Entering directory '/tmp/tmp.BkGP6nYoG4/1kk506cznml2m4vwsdis56l0wwdclcw5-source/src/include'
make[3]: Nothing to be done for 'all'.
make[3]: Leaving directory '/tmp/tmp.BkGP6nYoG4/1kk506cznml2m4vwsdis56l0wwdclcw5-source/src/include'
Making all in util
make[3]: Entering directory '/tmp/tmp.BkGP6nYoG4/1kk506cznml2m4vwsdis56l0wwdclcw5-source/src/util'
  CC       os_installation.lo
  CCLD     libsyncutil.la
rm -f sync-config sync-config.tmp && \
/nix/store/g5p3ky90xa05ggg5szyb0pbbl2vp7n03-gnused-4.9/bin/sed -e 's,%libdir%,/tmp/tmp.BkGP6nYoG4/outputs/out/lib,'g  sync-config.in >sync-config.tmp && \
chmod a-w+x sync-config.tmp && \
mv sync-config.tmp sync-config
make[3]: Leaving directory '/tmp/tmp.BkGP6nYoG4/1kk506cznml2m4vwsdis56l0wwdclcw5-source/src/util'
Making all in syncdb
make[3]: Entering directory '/tmp/tmp.BkGP6nYoG4/1kk506cznml2m4vwsdis56l0wwdclcw5-source/src/syncdb'
  CC       sync-dbinit.o
  CC       sync_db_plugin.lo
  CCLD     libsyncdb.la
  CCLD     sync-dbinit
  CC       plugin_syncdb_postgres.lo
plugin_syncdb_postgres.c: In function ‘postgres_store_payment’:
plugin_syncdb_postgres.c:505:36: warning: passing argument 1 of ‘TALER_PQ_query_param_amount’ from incompatible pointer type [-Wincompatible-pointer-types]
  505 |     TALER_PQ_query_param_amount (pg->conn,
      |                                  ~~^~~~~~
      |                                    |
      |                                    struct GNUNET_PQ_Context *
In file included from plugin_syncdb_postgres.c:25:
/nix/store/ql2zdaky3pjqibwiqzik4lcbwrdhyci9-taler-exchange-0.9.2/include/taler/taler_pq_lib.h:52:57: note: expected ‘const struct TALER_Amount *’ but argument is of type ‘struct GNUNET_PQ_Context *’
   52 | TALER_PQ_query_param_amount (const struct TALER_Amount *x);
      |                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~^
plugin_syncdb_postgres.c:505:5: error: too many arguments to function ‘TALER_PQ_query_param_amount’
  505 |     TALER_PQ_query_param_amount (pg->conn,
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/nix/store/ql2zdaky3pjqibwiqzik4lcbwrdhyci9-taler-exchange-0.9.2/include/taler/taler_pq_lib.h:52:1: note: declared here
   52 | TALER_PQ_query_param_amount (const struct TALER_Amount *x);
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
make[3]: *** [Makefile:891: plugin_syncdb_postgres.lo] Error 1
make[3]: Leaving directory '/tmp/tmp.BkGP6nYoG4/1kk506cznml2m4vwsdis56l0wwdclcw5-source/src/syncdb'
make[2]: *** [Makefile:411: all-recursive] Error 1
make[2]: Leaving directory '/tmp/tmp.BkGP6nYoG4/1kk506cznml2m4vwsdis56l0wwdclcw5-source/src'
make[1]: *** [Makefile:466: all-recursive] Error 1
make[1]: Leaving directory '/tmp/tmp.BkGP6nYoG4/1kk506cznml2m4vwsdis56l0wwdclcw5-source'
make: *** [Makefile:398: all] Error 2

I think it might be worth discussing this with a maintainer if possible.

@augustebaum augustebaum mentioned this issue Nov 10, 2023
13 tasks
@Enzime
Copy link
Collaborator

Enzime commented Nov 16, 2023

I ran into the same error above when trying to package the latest version of anastasis which should be fixed by using a newer version of taler-exchange.

I've made an upstream PR here:

NixOS/nixpkgs#267783

@alejandrosame
Copy link
Contributor

@Enzime we replicated the changes on your PR locally for the time being, and we successfully build taler-sync. It seems that they force pushed on the 0.9.3 tag, because we had to change the hash256 attribute to make it work.

@Enzime Enzime changed the title sync.git sync Dec 8, 2023
@Enzime Enzime changed the title sync taler-sync Dec 8, 2023
@Enzime
Copy link
Collaborator

Enzime commented Dec 8, 2023

I've made an upstream PR that should fix the hashes for the Taler packages:

NixOS/nixpkgs#272816

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NGI0 Review Funded through NGI Zero Review package Create a Nix package
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants