Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not throw error when command executed but no database connection #6

Open
kszymukowicz opened this issue Aug 3, 2024 · 2 comments

Comments

@kszymukowicz
Copy link

hi,

what you think about this?

This kind of behaviour is already in typo3-console command install:extensionsetupifpossible

https://github.com/TYPO3-Console/TYPO3-Console/blob/main/Classes/Console/Command/Install/InstallExtensionSetupIfPossibleCommand.php

My reasoning is the same as described in the above command:

$this->setHelp(
            <<<'EOH'
This command tries up all TYPO3 extensions, but quits gracefully if this is not possible.
This can be used in <code>composer.json</code> scripts to ensure that extensions
are always set up correctly after a composer run on development systems,
but does not fail on packaging for deployment where no database connection is available.

Besides that, it can be used for a first deploy of a TYPO3 instance in a new environment,
but also works for subsequent deployments.
EOH
        );
@nhovratov
Copy link
Owner

yes, we can of course do that! Do you want to provide a patch? Otherwise I can't say when I will have time.

@kszymukowicz
Copy link
Author

Tnx! I will provide PR, sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants