Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

Integration tests fail if run outside of business hours #609

Open
neilbmclaughlin opened this issue Oct 24, 2019 · 0 comments
Open

Integration tests fail if run outside of business hours #609

neilbmclaughlin opened this issue Oct 24, 2019 · 0 comments

Comments

@neilbmclaughlin
Copy link
Contributor

neilbmclaughlin commented Oct 24, 2019

The behaviour of the app changes depending on the time of day, specifically in or out of business hours. The behaviour change is which view is presented for the results page - nearby or nearby + open. During business hours the default view is nearby and outside business hours the default view is nearby + open.The tests fail because the nock's are set up with an assumption of the in business hours default view and therefore what the form of the query to azure search will be to mock.

Two possible solutions are:

  • explicitly set the open query parameter to not rely on the default behaviour
  • fix time using the override env var DATETIME (see README usage) for the tests which do not set the open parameter.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant