From dee0c7ee840d36f3457030bc44596df236ae62cc Mon Sep 17 00:00:00 2001 From: Frankie Roberto Date: Mon, 16 Sep 2024 12:23:28 +0100 Subject: [PATCH 1/4] Update changelog with breaking change notes --- CHANGELOG.md | 47 ++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 46 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c2243a727..5395af258 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,12 +2,57 @@ ## Unreleased +:boom: **Breaking changes** + +- Updated back link and breadcrumbs ([PR 1002](https://github.com/nhsuk/nhsuk-frontend/pull/1002)) + +The breadcrumbs component no longer contains its own `
` container. + +Instead, you should move it inside the existing `
` container for your overall page, but before the `
` tag. + +This means that instead this: + +```html + +
+
+ ... +
+
+``` + +You should have this: + +```html +
+ +
+ ... +
+
+``` + +The back link should also be placed within the `
` container but before the `
` tag, as before. + +The back link now contains some default margin above it, so you can remove any override classes you added previously, such as `nhsuk-u-margin-top-4`, these can now be removed. However you can still include override classes if you want more or less spacing than the default. + +:wrench: **Fixes** + - Fix Sass deprecation on `mix` function (passing a number without unit) ([PR 995](https://github.com/nhsuk/nhsuk-frontend/pull/995)) - Add nhsukAttributes macro, copied from GOV.UK ([PR 998](https://github.com/nhsuk/nhsuk-frontend/pull/998)) - Fix missing classes option for summary list rows ([PR 1007](https://github.com/nhsuk/nhsuk-frontend/pull/1007)) - Add support for inline conditions on summary list rows ([PR 1008](https://github.com/nhsuk/nhsuk-frontend/pull/1008)) - Change "Contact us" in the footer link examples to "Give us feedback" ([PR 972](https://github.com/nhsuk/nhsuk-frontend/pull/972)) -- Adjusted default spacing of back link component ([PR 964](https://github.com/nhsuk/nhsuk-frontend/pull/964)) - Reduce main wrapper padding on mobile ([PR 1003](https://github.com/nhsuk/nhsuk-frontend/pull/1003)) - Fix image encoding issue introduced in Gulp v5.0 ([PR 1013](https://github.com/nhsuk/nhsuk-frontend/pull/1013)) From b2cc1797a7cc6bb8b9f5bbea4696c34b32ee5862 Mon Sep 17 00:00:00 2001 From: Frankie Roberto Date: Mon, 16 Sep 2024 12:29:06 +0100 Subject: [PATCH 2/4] Remove trailing whitespace --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5395af258..b481a9382 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,7 +6,7 @@ - Updated back link and breadcrumbs ([PR 1002](https://github.com/nhsuk/nhsuk-frontend/pull/1002)) -The breadcrumbs component no longer contains its own `
` container. +The breadcrumbs component no longer contains its own `
` container. Instead, you should move it inside the existing `
` container for your overall page, but before the `
` tag. From e9b6c211884c94bd04c793925c8d066cff4d8778 Mon Sep 17 00:00:00 2001 From: Frankie Roberto Date: Mon, 16 Sep 2024 14:14:23 +0100 Subject: [PATCH 3/4] Fix typo: add missing 'of' Co-authored-by: Ed Horsford --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b481a9382..296051f1f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,7 +10,7 @@ The breadcrumbs component no longer contains its own `
` container for your overall page, but before the `
` tag. -This means that instead this: +This means that instead of this: ```html