-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Few things from initial installation #162
Comments
This is fairly standard Django behaviour when adding a non-nullable field to an existing model. |
We should definitely mention that |
I'm not 100% sure about this. Either:
I think the wagtail convention would be to make it mandatory and have a different page model for pages where the hero was not wanted. |
Has anything come of this issue or do we require some action against this? @chrimesdev @mikemonteith |
Still need to action the above, might be worth trying to do the setup again and see if similar (or other problems) arise |
I've recently spun up a blank Wagtail instance and installed this plugin, overall the setup process was really straight forward and it works perfectly. However there were just a few things stumbling blocks that I found, which slowed me down a little bit, but this might just be due to my general lack of Wagtail/Python knowledge.
When I tried to make migrations after adding the
StreamFieldPanel('body')
to my Homepage model. I got an error about a non-nullable field, I was given the option to populate the field with a value. At first I had no idea what the value should be, but then I tried"String"
but this threw an error so then I tried a blank string""
and this worked - just wondering if there could be any documentation for this or even a work around to avoid the error all together?When adding the Header component along with the site settings configuration. I added
'wagtailnhsukfrontend.settings'
to myINSTALLED_APPS
but didn't have‘wagtail.contrib.settings’
in there so it didn't work - again just wondering if this needs to be documented? Not sured if I should have had‘wagtail.contrib.settings’
by default!When adding the Hero component mixin to the Homepage model, it became a mandatory component/field within the admin for the Homepage. I didn't necessarily want to use the component straight away, but wanted to make it available on the Homepage incase I ever needed. I couldn't save the page without populating the Hero fields - could this component/fields be non mandatory?
These are probably small stupid things are the only issues I came across, otherwise I would have managed to setup the Wagtail instance with plugin installed within less than 5 minutes!
The text was updated successfully, but these errors were encountered: