Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not page chooser in blocks with URL field #174

Open
nickmoreton opened this issue Dec 15, 2020 · 2 comments
Open

Why not page chooser in blocks with URL field #174

nickmoreton opened this issue Dec 15, 2020 · 2 comments

Comments

@nickmoreton
Copy link
Contributor

Hi, thanks for this work!
More of a question than an issue but is there a reason the blocks that have URL fields don't have page chooser implemented. I'd like to add that into a project Im working on and wondering if to add the feature here or stay with extending them in the project only.

@mikemonteith
Copy link
Contributor

Thanks for the feedback @nickmoreton
We have never had the need for a page chooser on ActionLinkBlock or PromoBlock just because the way our site works, those blocks always link to external sites.

I think it would be good to add a page-chooser and some custom validation so that either page chooser or URL has to have a value.

Pull requests welcome 😄

@nickmoreton
Copy link
Contributor Author

Thanks for the reply @mikemonteith Yes I thought it would be a good idea too. Will get working on it and kill 2 birds with one stone :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants