Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event structure in 'Start Sync.vi' is not updating when we try to regenerate after adding a new rpc method in protofile #265

Closed
yash-ni opened this issue May 30, 2023 · 0 comments
Labels
type: bug Something isn't working

Comments

@yash-ni
Copy link
Collaborator

yash-ni commented May 30, 2023

When I try to add a new rpc method under a service in the protofile and then regenerate the server code, then the event structure (in Start Sync.vi) is not updating to show the newly added rpc method's event in it.

Software Environment:

  1. Windows 10
  2. Labview 2023 Q1 (64 bit)

Original Protofile "greet.proto" (before modifications) that I used to generate the code for the first time:

syntax = "proto3";

package newgreeter;

service Greeter {
    rpc SayHello (HelloRequest) returns (HelloReply);
    rpc ParrotSayHello (HelloRequest) returns (stream HelloReply);
    rpc ChattyClientSayHello (stream HelloRequest) returns (DelayedReply);
    rpc InteractingHello (stream HelloRequest) returns (stream HelloReply);
}

message HelloRequest{
    string message = 1;
}

message DelayedReply{
    string message = 1;
    repeated HelloRequest request = 2;
}

message HelloReply{
    string message = 1;
}

Code Generator configurations (will remain same):

generator

Steps to reproduce the error:

  1. Generate the code for the first time using the above protofile and generator configuration.

  2. You will notice the following events in the event structure in 'Start Sync.vi'

    event structure

  3. Now update the protofile by adding a new rpc method as given below:

    syntax = "proto3";
    
    package newgreeter;
    
    service Greeter {
        rpc SayHello (HelloRequest) returns (HelloReply);
        rpc ParrotSayHello (HelloRequest) returns (stream HelloReply);
        rpc ChattyClientSayHello (stream HelloRequest) returns (DelayedReply);
        rpc InteractingHello (stream HelloRequest) returns (stream HelloReply);
        rpc NewMethod (HelloRequest) returns (HelloReply);
    }
    
    message HelloRequest{
        string message = 1;
    }
    
    message DelayedReply{
        string message = 1;
        repeated HelloRequest request = 2;
    }
    
    message HelloReply{
        string message = 1;
    }
  4. Use the generator to generate server side code.

  5. You can see that the event structure is not updating and not adding the new method's event.

    new event structure

AB#2473751

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants