Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InStream.get_channels_buffer_size should not be public #621

Open
bkeryan opened this issue Jul 31, 2024 · 0 comments
Open

InStream.get_channels_buffer_size should not be public #621

bkeryan opened this issue Jul 31, 2024 · 0 comments

Comments

@bkeryan
Copy link
Collaborator

bkeryan commented Jul 31, 2024

InStream.get_channels_buffer_size and OutStream.get_channels_buffer_size were intended to be internal helper methods, but they don't have a leading underscore so this makes them undocumented public APIs. We should rename them to add a leading underscore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bkeryan