Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only add required dependencies to system definition #80

Open
buckd opened this issue Aug 1, 2023 · 0 comments
Open

Only add required dependencies to system definition #80

buckd opened this issue Aug 1, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@buckd
Copy link
Collaborator

buckd commented Aug 1, 2023

Is your feature request related to a problem? Please describe.
The current implementation of the custom device adds all DSF components present on the developer's machine as dependent files in the system definition even if some of the components are not required for the configuration. This causes errors in System Explorer if that sysdef is moved to a different machine that does not have all of the same components installed.

Describe the solution you'd like
Only required dependencies should be saved in the system definition.

Describe alternatives you've considered
Dependencies can be added at compile time by adding an ActionVIOnCompile. This removes errors if components are different across different machines. While this is a fairly simple change, the downside is now you will get no errors if a required component is not installed. Deciphering the error returned from VeriStand when a component is not installed is not simple.

Additional context
This isn't a huge issue for most users because if they use the .nipkg installer from the GitHub or the VeriStand suite, they will get all supported components, but for custom components, it would be nice to have this feature.

@buckd buckd added the enhancement New feature or request label Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant