Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy Frame times out on busy frames #48

Open
nick-prater opened this issue Jan 7, 2017 · 1 comment
Open

Copy Frame times out on busy frames #48

nick-prater opened this issue Jan 7, 2017 · 1 comment

Comments

@nick-prater
Copy link
Owner

Currently copy_frame uses the existing functions to place each jumper and circuit, which means every one is checked. All that checking is slow, and as we're copying from an existing frame which must be valid, there is no need to run the checks.

Solution: write some dedicated copy routines which don't bother about checks. Should be much faster.
@nick-prater
Copy link
Owner Author

For example of slowness... Copying the Global CTA2 frame currently takes 15 minutes! The browser times out and reports an error, but the copy does eventually complete if you're patient!

nick-prater added a commit that referenced this issue Jan 7, 2017
@nick-prater
Copy Frame/Template working
01afc8a 
But note issue #48. It's very slow, which causes a browser timeout
when copying large, busy frames. Despite the timeout, the database
does eventually get there.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nick-prater