Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter and return types, and consider using strict type mode #26

Open
nicolus opened this issue Sep 17, 2020 · 1 comment
Open

Comments

@nicolus
Copy link
Owner

nicolus commented Sep 17, 2020

See #24

PicoFeed now required PHP 7.1, but it's mostly still a PHP 5 library under the hood. Adding parameter and return type specifications and using strict mode throughout would help avoid problems like happened with #22, and would also help formalize the API.

@nicolus nicolus changed the title Consider using strict type mode Add parameter and return types, and consider using strict type mode Sep 17, 2020
@nicolus
Copy link
Owner Author

nicolus commented Sep 17, 2020

I'm all for adding Parameters and return types whenever possible. I'm not 100% sold on the whole strict types thing, but I can't argue that it would have prevented some bugs, so yeah that would probably be a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant