From a1d046d165735c4c57bc1db6f1e13bbaf7cf2ffd Mon Sep 17 00:00:00 2001 From: Ashley Stewart Date: Wed, 13 Dec 2023 11:48:25 +1000 Subject: [PATCH 1/5] Test adding npm install command --- .github/workflows/playwright.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/playwright.yml b/.github/workflows/playwright.yml index d7cad14..9f07a6a 100644 --- a/.github/workflows/playwright.yml +++ b/.github/workflows/playwright.yml @@ -14,7 +14,7 @@ jobs: with: node-version: 18 - name: Install dependencies - run: npm ci + run: npm install && npm ci working-directory: ./niivue - name: Install Playwright Browsers run: npx playwright install --with-deps From c100ca5b0a41ed965106df028ce0156f2de21a2a Mon Sep 17 00:00:00 2001 From: Ashley Stewart Date: Wed, 13 Dec 2023 11:49:27 +1000 Subject: [PATCH 2/5] Update playwrite test yaml --- .github/workflows/playwright.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/playwright.yml b/.github/workflows/playwright.yml index 9f07a6a..8db2925 100644 --- a/.github/workflows/playwright.yml +++ b/.github/workflows/playwright.yml @@ -1,7 +1,7 @@ name: Playwright Tests on: push: - branches: main + branches: test pull_request: branches: main jobs: From 9a6806f2582d0573447bbee9344dcb028dd7828f Mon Sep 17 00:00:00 2001 From: Ashley Stewart Date: Wed, 13 Dec 2023 11:54:10 +1000 Subject: [PATCH 3/5] Add yarn start:webview to yaml workflow --- .github/workflows/playwright.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/playwright.yml b/.github/workflows/playwright.yml index 8db2925..b70a132 100644 --- a/.github/workflows/playwright.yml +++ b/.github/workflows/playwright.yml @@ -20,7 +20,7 @@ jobs: run: npx playwright install --with-deps working-directory: ./niivue - name: Run Playwright tests - run: npx playwright test + run: yarn start:webview && npx playwright test working-directory: ./niivue - uses: actions/upload-artifact@v3 if: always() From 0fa8f4a673b3c0638e0efb921bc9cddc940d0858 Mon Sep 17 00:00:00 2001 From: Ashley Stewart Date: Wed, 13 Dec 2023 12:06:27 +1000 Subject: [PATCH 4/5] Update start webview command in workflow --- .github/workflows/playwright.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/playwright.yml b/.github/workflows/playwright.yml index b70a132..ec6f18a 100644 --- a/.github/workflows/playwright.yml +++ b/.github/workflows/playwright.yml @@ -16,11 +16,14 @@ jobs: - name: Install dependencies run: npm install && npm ci working-directory: ./niivue + - name: Start Webview + run: yarn start:webview & + working-directory: ./niivue - name: Install Playwright Browsers run: npx playwright install --with-deps working-directory: ./niivue - name: Run Playwright tests - run: yarn start:webview && npx playwright test + run: npx playwright test working-directory: ./niivue - uses: actions/upload-artifact@v3 if: always() From a4c80b255e5d7f25ed5198004a0d056ad94c157c Mon Sep 17 00:00:00 2001 From: Ashley Stewart Date: Wed, 13 Dec 2023 12:11:24 +1000 Subject: [PATCH 5/5] Update working directory for webview start in yaml workflow --- .github/workflows/playwright.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/playwright.yml b/.github/workflows/playwright.yml index ec6f18a..9edd8e9 100644 --- a/.github/workflows/playwright.yml +++ b/.github/workflows/playwright.yml @@ -18,7 +18,6 @@ jobs: working-directory: ./niivue - name: Start Webview run: yarn start:webview & - working-directory: ./niivue - name: Install Playwright Browsers run: npx playwright install --with-deps working-directory: ./niivue