Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhacements For JSON Schema #39

Open
rbrisita opened this issue Jun 19, 2018 · 2 comments
Open

Enhacements For JSON Schema #39

rbrisita opened this issue Jun 19, 2018 · 2 comments

Comments

@rbrisita
Copy link

This is in regard to JSON Schema file generation.

More Flexible Command Line

It would be great if the draft schema could be set for the generated file.

Testing integers and numbers

It seems that numeric data is always "number", which is used to denote floats. JSON Schema also has integers and would help in data verification.
@nijikokun
Copy link
Owner

Draft schema would require transformers for each draft, unless I have a misunderstanding with that request.

The second would be a great addition, would definitely accept a PR with that functionality.

rbrisita pushed a commit to rbrisita/generate-schema that referenced this issue Jul 7, 2018
Adding integer validation keyword for numeric instances and appropria…
417d59c 
…te tests. Hold nijikokun#39
@rbrisita rbrisita mentioned this issue Jul 7, 2018
Merged
nijikokun pushed a commit that referenced this issue Jan 23, 2019
@nijikokun
Adding integer validation keyword for numeric instances and appropria…
219ab0a 
…te tests. Hold #39
@legend80s
Copy link

Thanks for taking integer into account. But why this feature still not in the master branch? @nijikokun @rbrisita

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nijikokun @rbrisita @legend80s