First off, thank you for considering contributing to ordinare.
If you've noticed a bug or have a question you search the issue tracker to see if someone else in the community has already created a ticket. If not, go ahead and make one!
If this is something you think you can fix, then fork Active Admin and create a branch with a descriptive name.
A good branch name would be (where issue #325 is the ticket you're working on):
git checkout -b 325-add-japanese-translationsTo get the test suite running you can do:
bundle install
This will install RSpec needed to run the tests
bundle exec rspec
At this point, you're ready to make your changes! Feel free to ask for help; everyone is a beginner at first 😸
You should switch back to your master branch and make sure it's up to date with ordinare's master branch:
git remote add upstream [email protected]:nikolalsvk/ordinare.git
git checkout master
git pull upstream masterThen update your feature branch from your local copy of master, and push it!
git checkout 325-add-japanese-translations
git rebase master
git push --set-upstream origin 325-add-japanese-translationsFinally, go to GitHub and make a Pull Request :D
Semaphore will run our tests and report back with tests results.
If a maintainer asks you to "rebase" your PR, they're saying that a lot of code has changed, and that you need to update your branch so it's easier to merge.
To learn more about rebasing in Git, there are a lot of good resources, but here's the suggested workflow:
git checkout 325-add-japanese-translations
git pull --rebase upstream master
git push --force-with-lease 325-add-japanese-translations