Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zipfiles library does not work with Unicode. #34

Open
puruneko opened this issue Dec 16, 2018 · 2 comments
Open

zipfiles library does not work with Unicode. #34

puruneko opened this issue Dec 16, 2018 · 2 comments

Comments

@puruneko
Copy link

Problem

zipfiles library does not work against a filename with Unicode(multibyte character).
(ex : 【αβγ★】.zip)

Temporary solution

I tried sending WideCString in nim and recieving wchar_t pointer in C at calling 'zip_open' in libzip_all.c library.
(have to fix zipfiles.nim, libzip.nim, and libzip_all.c)
It seems looks working fine.
But, this solution is maybe only valid in 'zipfiles.open' on Windows platform.

Permanent solution

How to comply with Unicode as a whole ?
Please give me a hand...

@Araq
Copy link
Member

Araq commented Dec 16, 2018

Is that even fixable on our side? Nim supports Windows Unicode filenames just fine, it must be in the C code. And wchar_t shouldn't be required.

@puruneko
Copy link
Author

Ok, understood.
So, in this case, who should i ask ?
Or should i write codes around opening zipfile with native Nim ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants