Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Configuration GPU Setting in the README #22

Open
ZaydH opened this issue Jan 11, 2021 · 1 comment
Open

Default Configuration GPU Setting in the README #22

ZaydH opened this issue Jan 11, 2021 · 1 comment

Comments

@ZaydH
Copy link
Contributor

ZaydH commented Jan 11, 2021

In the README, it states:

gpu: Default = -1, -1 for calculation on the CPU otherwise GPU id

If I am understanding the meaning of "default" here, you are referring to the function get_default_config. Looking at that function's definition, it looks like the default value appears to be 0.

Assuming my understanding is correct and there is an issue, I am happy to submit a pull request to either update get_default_config to match the README or vice version -- whichever is correct. If I misunderstood the meaning of "default" please feel free to close.

@ZaydH
Copy link
Contributor Author

ZaydH commented Jan 11, 2021

After submitting this case, I noticed that scale and damp have different values listed as default than in get_default_config. Both are None in the code but in the README it says:

damp: Default = 0.01, damping factor during s_test calculation.
scale: Default = 25, scaling factor during s_test calculation.

That makes me think more that "default" does not refer to get_default_config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant