Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing elements & clarification when calculating s_test #33

Open
fotinidelig opened this issue May 4, 2022 · 0 comments
Open

Missing elements & clarification when calculating s_test #33

fotinidelig opened this issue May 4, 2022 · 0 comments

Comments

@fotinidelig
Copy link

Hello and thank you for the neat implementation!
In influence_function.py there are some things that aren't very clear to me in comparison to the paper.
First of all, here the computation for s_test is missing a multiplication imo. Shouldn't it be like this (?):

h_estimate = [ _v + ((1 - damp) * _h_e - _hv / scale)*_v
                      for _v, _h_e, _hv in zip(v, h_estimate, hv)]

according to this:
image

Furthermore, it is not obvious to me why in this func. you chose to apply grad() a second time after calculating the lement wise product. Is there a difference with running it two times beforehand?

Thank you and cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant