You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello and thank you for the neat implementation!
In influence_function.py there are some things that aren't very clear to me in comparison to the paper.
First of all, here the computation for s_test is missing a multiplication imo. Shouldn't it be like this (?):
Furthermore, it is not obvious to me why in this func. you chose to apply grad() a second time after calculating the lement wise product. Is there a difference with running it two times beforehand?
Thank you and cheers!
The text was updated successfully, but these errors were encountered:
Hello and thank you for the neat implementation!
In
influence_function.py
there are some things that aren't very clear to me in comparison to the paper.First of all, here the computation for s_test is missing a multiplication imo. Shouldn't it be like this (?):
according to this:
Furthermore, it is not obvious to me why in this func. you chose to apply grad() a second time after calculating the lement wise product. Is there a difference with running it two times beforehand?
Thank you and cheers!
The text was updated successfully, but these errors were encountered: