Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps log recovery (truncate) is performed even in dry run mode #604

Open
maximuska opened this issue Jun 24, 2013 · 4 comments
Open

deps log recovery (truncate) is performed even in dry run mode #604

maximuska opened this issue Jun 24, 2013 · 4 comments

Comments

@maximuska
Copy link
Contributor

While running 'ninja -n -d explain' got:
ninja: warning: premature end of file; recovering

The deps file was truncated, w/o leaving any evidence of what the problem was.

@nico
Copy link
Collaborator

nico commented Jun 24, 2013

Is this a bug though? dry run mode means "don't run any build edges", which didn't happen.

(Also, was this with trunk ninja? Trunk should flush records after they're written.)

@maximuska
Copy link
Contributor Author

Matter of definition, I guess. What the use-cases for the "dry run" are?
In the specific case it would be much better if ninja wouldn't touch the logs, as I could investigate these then.

As for your question, it has happened with ninja based on master with newish fflushes code. ninja always runs till the end uninterrupted in the tests, and I am out of sane ideas for what the problem is, but something is very wrong there. I've now added more logs and assertions to test for ret values of all fwrites/fflushes to debug this (the code still passes the tests;)

I am running this builds with 'ionice' in parallel to my regular activity (but in a completely separate build tree), but I am not sure if this is related.

@maximuska
Copy link
Contributor Author

(the log corruption is likely explainable by #605)

@jonesmz

This comment was marked as abuse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants