Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove -t msvc #735

Open
sgraham opened this issue Apr 14, 2014 · 2 comments
Open

Remove -t msvc #735

sgraham opened this issue Apr 14, 2014 · 2 comments
Labels
Milestone

Comments

@sgraham
Copy link
Contributor

sgraham commented Apr 14, 2014

Its functionality is (almost entirely) subsumed by deps=msvc. The only thing that it's used for is to help gyp. Gyp needs to set the environment that the compiler is run in, and this was stuffed into -t msvc out of convenience long ago.

At this point -t msvc is just confusing, and should be removed, with gyp fending for itself in some other way (perhaps by adding an env_block variable to ninja).

@nico
Copy link
Collaborator

nico commented Nov 1, 2014

Related thread: https://groups.google.com/forum/#!topic/ninja-build/H7lMfaEVqzc On this thread, I argue that we should remove deps=msvc instead.

@nico
Copy link
Collaborator

nico commented Nov 1, 2014

(but neither change is backward-compatible, so neither's likely going to happen unless we do a not-background-compat release)

@jhasse jhasse added the windows label Nov 7, 2018
@jhasse jhasse added this to the 2.0.0 milestone Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants