Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nativemax and nativemin as space resolutions #889

Open
tsalo opened this issue Aug 12, 2024 · 2 comments
Open

Support nativemax and nativemin as space resolutions #889

tsalo opened this issue Aug 12, 2024 · 2 comments

Comments

@tsalo
Copy link
Contributor

tsalo commented Aug 12, 2024

What would you like to see added in this software?

This stems from PennLINC/qsiprep#681, as DWI reconstruction tools require isotropic voxels, but native voxel sizes aren't always isotropic, so our idea was to accept nativemax and nativemin options.

Do you have any interest in helping implement the feature?

Yes

Additional information / screenshots

No response

@effigies
Copy link
Member

Maybe the way to go here is to provide an API to register a space, e.g.,

ReferenceSpaces.register(
    'nativemin',
    Description='Data resampled to isotropic voxels matching minimum of native voxel sizes',
)

Then downstream workflows do not need to rely on releases to get the features they need.

@tsalo
Copy link
Contributor Author

tsalo commented Aug 12, 2024

That sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants