Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance dataset_description and sidecars to please the new bids_validator #809

Open
1 of 2 tasks
bpinsard opened this issue Dec 10, 2024 · 0 comments
Open
1 of 2 tasks

Comments

@bpinsard
Copy link
Contributor

Summary

Running the new bids-validator I get more warnings than with the older one.
eg

	[WARNING] JSON_KEY_RECOMMENDED A JSON file is missing a key listed as recommended.
		DatasetType
		/dataset_description.json

		GeneratedBy
		/dataset_description.json

		SourceDatasets
		/dataset_description.json

So we should maybe improve the currently generated dataset_description.json to include such tags.

It also get errors such as

	[ERROR] SIDECAR_KEY_REQUIRED A data file's JSON sidecar is missing a key listed as required.
		Units
		/sub-participant/ses-43/anat/sub-participant_ses-43_acq-stagefa5_echo-1_part-phase_MEGRE.nii.gz
		/sub-participant/ses-43/anat/sub-participant_ses-43_acq-stagefa5_echo-2_part-phase_MEGRE.nii.gz

So it seems that all part-phase should have Units defined in the json, in most cases this would be arbitrary.
As heudiconv can set part-phase after dcm2niix in update_complex_name, it should be done in heudiconv.

Platform details:

Choose one:

  • Local environment
  • Container
  • Heudiconv version:

1.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant