forked from bcotton/selenium-grid
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selenium Grid with Selenium 2.0b1 #6
Open
sponte
wants to merge
14
commits into
nirvdrum:master
Choose a base branch
from
sponte:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… can't read HttpServletReqest body more than once Updated HttpClient.java to be aware of WebDriver (/wd/hub) requests Adding equals method to HttpParameters class (to make unit tests pass) Adding Headers[] to Response class to make it compatible with webdriver Adding WebDriver specific commands hub/commands/webdriver/* Updating RemoteControlProxy, HttpCommandParser, HubServlet to be aware of WebDriver requests
… can't read HttpServletReqest body more than once Updated HttpClient.java to be aware of WebDriver (/wd/hub) requests Adding equals method to HttpParameters class (to make unit tests pass) Adding Headers[] to Response class to make it compatible with webdriver Adding WebDriver specific commands hub/commands/webdriver/* Updating RemoteControlProxy, HttpCommandParser, HubServlet to be aware of WebDriver requests
… can't read HttpServletReqest body more than once Updated HttpClient.java to be aware of WebDriver (/wd/hub) requests Adding equals method to HttpParameters class (to make unit tests pass) Adding Headers[] to Response class to make it compatible with webdriver Adding WebDriver specific commands hub/commands/webdriver/* Updating RemoteControlProxy, HttpCommandParser, HubServlet to be aware of WebDriver requests
Making junit fork
Making junit fork Webdriver doesn't raise exceptions when it terminates sessions
Making junit fork Webdriver doesn't raise exceptions when it terminates sessions
Hi Stan, Sorry for not responding for a while on this. I've been working behind the scenes to get a useful code contribution out in the open. If you haven't seen yet, I've started a discussion on the Selenium dev list about a new grid donation that is WebDriver compatible. I'd love to get your feedback on it. Thanks, |
Conflicts: project.properties vendor/selenium-server-standalone-2.0a7.jar vendor/selenium-server-standalone-2.0b1.jar vendor/selenium-server-standalone-2.0b3.jar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have been trying to implement WebDriver remote into your grid and have a working version. I understand that there are plenty of things that should have been done slightly different way but with limited resources I had this is what I came up with.
This really isn't a pull request because I don't expect you to take it in the current for but I think it could be a beginning of a longer discussion.
Thanks,
Stan