Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small Accessibility Adjustments #2

Open
3 tasks
nisarhassan12 opened this issue May 24, 2020 · 1 comment
Open
3 tasks

Small Accessibility Adjustments #2

nisarhassan12 opened this issue May 24, 2020 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@nisarhassan12
Copy link
Owner

Feedback from Ahmad Shadeed. I think it's worth making the changes for things that he pointed out.

  • The button text color "Get in touch" is not clear for me, I think it has to be pure white
  • The github link next to "View site" needs a revisit. A screen reader will read it as "Github", which is not clear.
  • The alt attribute should be more clear
@nisarhassan12 nisarhassan12 added help wanted Extra attention is needed good first issue Good for newcomers labels May 24, 2020
@Vikram-Hegde
Copy link

Hey There I have fixed the above problems by cloning the project in my desktop ! How can I send the project here for PR (Note: I'm a newbie at contributing )

@Vikram-Hegde Vikram-Hegde mentioned this issue Jul 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed some accessibility issues
2 participants
@nisarhassan12 @Vikram-Hegde