Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stricter requirements for directive comments #70

Closed
nishanths opened this issue Nov 11, 2023 · 0 comments · Fixed by #72
Closed

stricter requirements for directive comments #70

nishanths opened this issue Nov 11, 2023 · 0 comments · Fixed by #72

Comments

@nishanths
Copy link
Owner

nishanths commented Nov 11, 2023

For example, the current code in master considers comments of the form:

//exhaustive:ignore-more-text

to be a valid equivalent of:

//exhaustive:ignore

We don't wish to allow the above forms as an equivalent. This will be a breaking change for users who didn't use the strictly exact form.

That said, the following should continue to be allowed (notice instead of -):

//exhaustive:ignore more-text

See discussion here: #68 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant