Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy data quirks #161

Open
tomalrussell opened this issue Aug 23, 2023 · 0 comments
Open

Tidy data quirks #161

tomalrussell opened this issue Aug 23, 2023 · 0 comments
Assignees

Comments

@tomalrussell
Copy link
Member

See below the list of quirks compiled by @mz8i that we introduced before the release. The first two points are the main ones. 3-4 is just a matter of consistency, in code it'd mostly appear in formatting contexts.

  1. Inconsistent feature property naming - src/config/assets/data-access.ts , src/details/features/damages/DamagesSection.tsx#38
  • hazard:
    • Instead of “fluvial”, there is “river” e.g. ead__river__rcp_rcp4p5__epoch_2050
  • RCP:
    • For road and rail, “baseline” is “historical” e.g. ead__river__rcp_historical__epoch_1980
    • Instead of “rcp_4.5” there’s “rcp_rcp4p5” e.g. ead__river__rcp_rcp4p5__epoch_2050
  • Epoch:
    • For cyclones, “present” is 2020, e.g. ead__cyclone__rcp_baseline__epoch_2020
    • For road and rail, “present” is 1980, e.g. ead__river__rcp_historical__epoch_1980
  1. Cyclones - epoch, rcp are missing in db - src/state/data-domains/hazards.ts#39
  • Epoch: present / 2050
  • Rcp: baseline / 8x5
  • based on whether gcm = ‘constant’
  1. Epoch consistency in api -> domains - values across different datasets: [2010], present, baseline
  • fluvial, coastal - present
  • extreme_heat, drought - baseline
  • Previously (Jamaica) - was 2010
  1. Gcm consistency in api -> domains:
  • fluvial, cyclone - capitalised / “constant”
  • coastal - “None”
  • extreme_heat, drought - lowercase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant