Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: 4 home-manager tests broken by recent nixpkgs update #6049

Open
2 tasks done
RedEtherbloom opened this issue Nov 6, 2024 · 4 comments · May be fixed by #6051
Open
2 tasks done

bug: 4 home-manager tests broken by recent nixpkgs update #6049

RedEtherbloom opened this issue Nov 6, 2024 · 4 comments · May be fixed by #6051
Assignees
Labels
bug triage Issues or feature request that have not been triaged yet

Comments

@RedEtherbloom
Copy link

Are you following the right branch?

  • My Nixpkgs and Home Manager versions are in sync

Is there an existing issue for this?

  • I have searched the existing issues

Issue description

At some point since the last successful flake.lock update a change to nixpkgs seems to have changed how certain files in the TOML and YAML filetype gety generated.

This results in 4 test cases failing:

alacritty-merging-settings
alacritty-merging-settings: FAILED
Expected home-files/.config/alacritty/alacritty.toml to be same as /nix/store/3vva42k10x0v1cwpz77rl6fx46d3r2x8-settings-toml-expected.toml but were different:
--- actual
+++ expected
@@ -1,3 +1,4 @@
+[font]
 [font.bold]
 family = "SFMono"
 
For further reference please introspect /nix/store/dlhsx7z20izbzbscknqxfgaigddksvqz-nmt-report-alacritty-merging-settings
alacritty-toml-config
alacritty-toml-config: FAILED
Expected home-files/.config/alacritty/alacritty.toml to be same as /nix/store/3vva42k10x0v1cwpz77rl6fx46d3r2x8-settings-toml-expected.toml but were different:
--- actual
+++ expected
@@ -1,3 +1,4 @@
+[font]
 [font.bold]
 family = "SFMono"
 
For further reference please introspect /nix/store/cbp0z54h15y0zbsj8kf4f6d4sc354xz9-nmt-report-alacritty-toml-config
espanso-basic-configuration
espanso-basic-configuration: FAILED
Expected home-files/.config/espanso/match/base.yml to be same as /nix/store/ayhphlwrw71hcay8iq97p68zmn720fb8-basic-matches.yaml but were different:
--- actual
+++ expected
@@ -10,7 +10,9 @@
 matches:
 - replace: It's {{currentdate}} {{currenttime}}
   trigger: :now
-- replace: "line1\nline2"
+- replace: 'line1
+
+    line2'
   trigger: :hello
 - regex: :hi(?P<person>.*)\.
   replace: Hi {{person}}!
For further reference please introspect /nix/store/agjrp2lrk880qnwad2iihzc8cniw0jh9-nmt-report-espanso-basic-configuration
spotify-player-settings
spotify-player-settings: FAILED
Expected home-files/.config/spotify-player/theme.toml to be same as /nix/store/i6imsp1kp42ikphsq3yc5bhv4pd07h5i-theme.toml but were different:
--- actual
+++ expected
@@ -1,6 +1,7 @@
 [[themes]]
 name = "default2"
 
+[themes.component_style]
 [themes.component_style.block_title]
 fg = "Magenta"
 
For further reference please introspect /nix/store/nzag3700di81hnx8jv9s6f377yi5ci1r-nmt-report-spotify-player-settings

This mirrors home-manager-bots failed flake.lock update from today: CI link

The first nixpkgs that I tried was 7ffd9ae656aec493492b44d0ddfb28e79a1ea25 from my PRs own bump commit yesterday.

Maintainer CC

Alacritty TOML: @r-vdp
Espanso YAML: @liyangau
Spotify-Player TOML: @diniamo

System information

- system: `"x86_64-linux"`
- host os: `Linux 6.11.6, NixOS, 24.11 (Vicuna), 24.11.20241102.7ffd9ae`
- multi-user?: `yes`
- sandbox: `yes`
- version: `nix-env (Nix) 2.24.9`
- channels(root): `"nixos"`
- nixpkgs: `/nix/store/zq2axpgzd5kykk1v446rkffj3bxa2m2h-source`
@RedEtherbloom RedEtherbloom added bug triage Issues or feature request that have not been triaged yet labels Nov 6, 2024
@diniamo
Copy link
Contributor

diniamo commented Nov 6, 2024

ilovenixpkgsilovenixpkgsilovenixpkgsilovenixpkgsilovenixpkgsilovenixpkgsilovenixpkgsilovenixpkgsilovenixpkgsilovenixpkgsilovenixpkgsilovenixpkgsilovenixpkgsilovenixpkgsilovenixpkgsilovenixpkgsilovenixpkgsilovenixpkgsilovenixpkgsilovenixpkgsilovenixpkgs

@RedEtherbloom
Copy link
Author

Any good way to show the differences between two nixpkgs revs? I only found commands that look like they require building two entire sets of nixpkgs first

@r-vdp
Copy link
Contributor

r-vdp commented Nov 6, 2024

This is only affecting the tests, right? The generated files are not invalid?

If so, I guess we just need to update the tests.

@RedEtherbloom
Copy link
Author

This is only affecting the tests, right? The generated files are not invalid?

If so, I guess we just need to update the tests.

As far as I can tell, yes. It's also only removing superfluous blocks with no keys(e.g. font when only under font.bold are keys).
If none of the applications care about those this should be trivial.

@RedEtherbloom RedEtherbloom linked a pull request Nov 6, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug triage Issues or feature request that have not been triaged yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants