Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixpkgs-update workers are occasionally eating garbage #799

Closed
rhendric opened this issue Aug 31, 2023 · 2 comments · Fixed by #833
Closed

nixpkgs-update workers are occasionally eating garbage #799

rhendric opened this issue Aug 31, 2023 · 2 comments · Fixed by #833

Comments

@rhendric
Copy link
Member

The FIFO used to communicate between fetchers and workers is not a safe replacement for a proper task queue.

Excerpts from https://r.ryantm.com/log/~workers/2023-08-31-worker1.stderr.log:

+ /var/lib/nixpkgs-update/bin/nixpkgs-update update-batch --pr --outpaths --nixpkgs-review 'rg.r/rjc/tlasle/esoshaskellPackages.llvm-dsl 0.0 0.1 https://repology.org/project/haskell:llvm-dsl/versions'
[...]
+ /var/lib/nixpkgs-update/bin/nixpkgs-update update-batch --pr --outpaths --nixpkgs-review 'ython31akgsti-esce .0201. tp:/eooyogpoetpto:rowboktvrin'

And from https://r.ryantm.com/log/~workers/2023-08-31-worker2.stderr.log:

+ /var/lib/nixpkgs-update/bin/nixpkgs-update update-batch --pr --outpaths --nixpkgs-review 'p1Pcae.rowbokt01. .03hts/rplg.r/rjc/yhnti-esce/esoskabeljau 1.2.0 2.0.0 https://repology.org/project/kabeljau/versions'

I want to replace the FIFO with a queue service using sockets, and make the queue a least-recently-updated priority queue while I'm at it; this issue is just advance warning of my intentions, in case they interfere with someone else's.

@zowoq
Copy link
Contributor

zowoq commented Aug 31, 2023

cc @ryantm

@zowoq
Copy link
Contributor

zowoq commented Aug 31, 2023

Bit of a tangent but it would be useful if we had some way of verifying the bot is actually working, e.g. check if the bot has opened a PR in nixpkgs the last few hours and fire an alert if it hasn't. Twice now the bot has been broken and I only noticed because it hadn't opened any PRs for a day or two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants