Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] write-good fails on fixupPhase #3003

Closed
1 task done
pinarruiz opened this issue Feb 12, 2025 · 1 comment
Closed
1 task done

[BUG] write-good fails on fixupPhase #3003

pinarruiz opened this issue Feb 12, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@pinarruiz
Copy link
Contributor

Field Description
Plugin none-ls -> write_good
Nixpkgs unstable (44534bc0)
Home Manager release-24.11 (bd65bc3)
  • I have read the FAQ and my bug is not listed there.

Description

When setting plugins.none-ls.sources.diagnostics.write_good.enable to true, the package starts to build but on the fixupPhase I get the following error:

Finished npmInstallHook
Running phase: fixupPhase
@nix { "action": "setPhase", "phase": "fixupPhase" }
shrinking RPATHs of ELF executables and libraries in /nix/store/wycfk8ifw1wbfwfp5hpnf55wqvhhhrxq-write-good-1.0.8
checking for references to /build/ in /nix/store/wycfk8ifw1wbfwfp5hpnf55wqvhhhrxq-write-good-1.0.8...
patching script interpreter paths in /nix/store/wycfk8ifw1wbfwfp5hpnf55wqvhhhrxq-write-good-1.0.8
/nix/store/wycfk8ifw1wbfwfp5hpnf55wqvhhhrxq-write-good-1.0.8/lib/node_modules/write-good/bin/write-good.js: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/i1jdnip70qb7yh4krlzsgyxs0zdvw7xv-nodejs-22.13.1/bin/node"
ERROR: noBrokenSymlinks: the symlink /nix/store/wycfk8ifw1wbfwfp5hpnf55wqvhhhrxq-write-good-1.0.8/lib/node_modules/write-good/node_modules/.bin/js-yaml points to a missing target /nix/store/wycfk8ifw1wbfwfp5hpnf55wqvhhhrxq-write-good-1.0.8/lib/node_modules/write-good/node_modules/js-yaml/bin/js-yaml.js
ERROR: noBrokenSymlinks: the symlink /nix/store/wycfk8ifw1wbfwfp5hpnf55wqvhhhrxq-write-good-1.0.8/lib/node_modules/write-good/node_modules/.bin/semver points to a missing target /nix/store/wycfk8ifw1wbfwfp5hpnf55wqvhhhrxq-write-good-1.0.8/lib/node_modules/write-good/node_modules/semver/bin/semver
ERROR: noBrokenSymlinks: the symlink /nix/store/wycfk8ifw1wbfwfp5hpnf55wqvhhhrxq-write-good-1.0.8/lib/node_modules/write-good/node_modules/.bin/grunt points to a missing target /nix/store/wycfk8ifw1wbfwfp5hpnf55wqvhhhrxq-write-good-1.0.8/lib/node_modules/write-good/node_modules/grunt/bin/grunt
ERROR: noBrokenSymlinks: the symlink /nix/store/wycfk8ifw1wbfwfp5hpnf55wqvhhhrxq-write-good-1.0.8/lib/node_modules/write-good/node_modules/.bin/coffee points to a missing target /nix/store/wycfk8ifw1wbfwfp5hpnf55wqvhhhrxq-write-good-1.0.8/lib/node_modules/write-good/node_modules/coffeescript/bin/coffee
ERROR: noBrokenSymlinks: the symlink /nix/store/wycfk8ifw1wbfwfp5hpnf55wqvhhhrxq-write-good-1.0.8/lib/node_modules/write-good/node_modules/.bin/esvalidate points to a missing target /nix/store/wycfk8ifw1wbfwfp5hpnf55wqvhhhrxq-write-good-1.0.8/lib/node_modules/write-good/node_modules/esprima/bin/esvalidate.js
ERROR: noBrokenSymlinks: the symlink /nix/store/wycfk8ifw1wbfwfp5hpnf55wqvhhhrxq-write-good-1.0.8/lib/node_modules/write-good/node_modules/.bin/atob points to a missing target /nix/store/wycfk8ifw1wbfwfp5hpnf55wqvhhhrxq-write-good-1.0.8/lib/node_modules/write-good/node_modules/atob/bin/atob.js
ERROR: noBrokenSymlinks: the symlink /nix/store/wycfk8ifw1wbfwfp5hpnf55wqvhhhrxq-write-good-1.0.8/lib/node_modules/write-good/node_modules/.bin/r_js points to a missing target /nix/store/wycfk8ifw1wbfwfp5hpnf55wqvhhhrxq-write-good-1.0.8/lib/node_modules/write-good/node_modules/requirejs/bin/r.js
ERROR: noBrokenSymlinks: the symlink /nix/store/wycfk8ifw1wbfwfp5hpnf55wqvhhhrxq-write-good-1.0.8/lib/node_modules/write-good/node_modules/.bin/esparse points to a missing target /nix/store/wycfk8ifw1wbfwfp5hpnf55wqvhhhrxq-write-good-1.0.8/lib/node_modules/write-good/node_modules/esprima/bin/esparse.js
ERROR: noBrokenSymlinks: the symlink /nix/store/wycfk8ifw1wbfwfp5hpnf55wqvhhhrxq-write-good-1.0.8/lib/node_modules/write-good/node_modules/.bin/eslint points to a missing target /nix/store/wycfk8ifw1wbfwfp5hpnf55wqvhhhrxq-write-good-1.0.8/lib/node_modules/write-good/node_modules/eslint/bin/eslint.js
ERROR: noBrokenSymlinks: the symlink /nix/store/wycfk8ifw1wbfwfp5hpnf55wqvhhhrxq-write-good-1.0.8/lib/node_modules/write-good/node_modules/.bin/r.js points to a missing target /nix/store/wycfk8ifw1wbfwfp5hpnf55wqvhhhrxq-write-good-1.0.8/lib/node_modules/write-good/node_modules/requirejs/bin/r.js
ERROR: noBrokenSymlinks: the symlink /nix/store/wycfk8ifw1wbfwfp5hpnf55wqvhhhrxq-write-good-1.0.8/lib/node_modules/write-good/node_modules/.bin/rimraf points to a missing target /nix/store/wycfk8ifw1wbfwfp5hpnf55wqvhhhrxq-write-good-1.0.8/lib/node_modules/write-good/node_modules/rimraf/bin.js
ERROR: noBrokenSymlinks: the symlink /nix/store/wycfk8ifw1wbfwfp5hpnf55wqvhhhrxq-write-good-1.0.8/lib/node_modules/write-good/node_modules/.bin/nopt points to a missing target /nix/store/wycfk8ifw1wbfwfp5hpnf55wqvhhhrxq-write-good-1.0.8/lib/node_modules/write-good/node_modules/nopt/bin/nopt.js
ERROR: noBrokenSymlinks: the symlink /nix/store/wycfk8ifw1wbfwfp5hpnf55wqvhhhrxq-write-good-1.0.8/lib/node_modules/write-good/node_modules/.bin/jasmine-node points to a missing target /nix/store/wycfk8ifw1wbfwfp5hpnf55wqvhhhrxq-write-good-1.0.8/lib/node_modules/write-good/node_modules/jasmine-node/bin/jasmine-node
ERROR: noBrokenSymlinks: the symlink /nix/store/wycfk8ifw1wbfwfp5hpnf55wqvhhhrxq-write-good-1.0.8/lib/node_modules/write-good/node_modules/.bin/acorn points to a missing target /nix/store/wycfk8ifw1wbfwfp5hpnf55wqvhhhrxq-write-good-1.0.8/lib/node_modules/write-good/node_modules/acorn/bin/acorn
ERROR: noBrokenSymlinks: the symlink /nix/store/wycfk8ifw1wbfwfp5hpnf55wqvhhhrxq-write-good-1.0.8/lib/node_modules/write-good/node_modules/.bin/mkdirp points to a missing target /nix/store/wycfk8ifw1wbfwfp5hpnf55wqvhhhrxq-write-good-1.0.8/lib/node_modules/write-good/node_modules/mkdirp/bin/cmd.js
ERROR: noBrokenSymlinks: the symlink /nix/store/wycfk8ifw1wbfwfp5hpnf55wqvhhhrxq-write-good-1.0.8/lib/node_modules/write-good/node_modules/.bin/loose-envify points to a missing target /nix/store/wycfk8ifw1wbfwfp5hpnf55wqvhhhrxq-write-good-1.0.8/lib/node_modules/write-good/node_modules/loose-envify/cli.js
ERROR: noBrokenSymlinks: the symlink /nix/store/wycfk8ifw1wbfwfp5hpnf55wqvhhhrxq-write-good-1.0.8/lib/node_modules/write-good/node_modules/.bin/json5 points to a missing target /nix/store/wycfk8ifw1wbfwfp5hpnf55wqvhhhrxq-write-good-1.0.8/lib/node_modules/write-good/node_modules/json5/lib/cli.js
ERROR: noBrokenSymlinks: the symlink /nix/store/wycfk8ifw1wbfwfp5hpnf55wqvhhhrxq-write-good-1.0.8/lib/node_modules/write-good/node_modules/.bin/cake points to a missing target /nix/store/wycfk8ifw1wbfwfp5hpnf55wqvhhhrxq-write-good-1.0.8/lib/node_modules/write-good/node_modules/coffeescript/bin/cake
ERROR: noBrokenSymlinks: the symlink /nix/store/wycfk8ifw1wbfwfp5hpnf55wqvhhhrxq-write-good-1.0.8/lib/node_modules/write-good/node_modules/.bin/which points to a missing target /nix/store/wycfk8ifw1wbfwfp5hpnf55wqvhhhrxq-write-good-1.0.8/lib/node_modules/write-good/node_modules/which/bin/which
ERROR: noBrokenSymlinks: found 19 dangling symlinks and 0 reflexive symlinks

Minimal, Reproducible Example (MRE)

programs.nixvim.plugins.none-ls = {
    enable = true;
    sources.diagnostics.write_good.enable = true;
};
@pinarruiz pinarruiz added the bug Something isn't working label Feb 12, 2025
@MattSturgeon
Copy link
Member

MattSturgeon commented Feb 12, 2025

This is an issue in upstream nixpkgs, unrelated to nixvim.

The write-good package is failing the new broken symlink checks added by NixOS/nixpkgs#370750

You can avoid this issue by using the nixpkgs revision that nixvim is currently using, instead of setting your own follows.

Nixvim runs extensive tests against nixpkgs before we bump our flake.lock. Our current update PR (#2991) is blocked because of several issues like this.

To allow nixvim to use the most recent nixpkgs version we've tested against, you can just remove any inputs.nixvim.inputs.nixpkgs.follows from your flake.nix and run nix flake lock.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants