Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitlab-show-projects crashes if owner column is nil #6

Open
thomasf opened this issue Apr 19, 2015 · 9 comments
Open

gitlab-show-projects crashes if owner column is nil #6

thomasf opened this issue Apr 19, 2015 · 9 comments
Labels

Comments

@thomasf
Copy link

thomasf commented Apr 19, 2015

I do not currently know why its nil.

Debugger entered--Lisp error: (wrong-type-argument stringp nil)
  string-width(nil)
  tabulated-list-print-col(1 nil 28)
  tabulated-list-print-entry("311" ["somethingdocker-drone" nil "docker-containers" "Docker configuration for https://drone.something.se"])
  apply(tabulated-list-print-entry ("311" ["somethingdocker-drone" nil "docker-containers" "Docker configuration for https://drone.something.se"]))
  tabulated-list-print(t)
  gitlab-show-projects()
  call-interactively(gitlab-show-projects record nil)
  command-execute(gitlab-show-projects record)
  execute-extended-command(nil "gitlab-show-projects")
  ...
@nlamirault nlamirault added the bug label Apr 19, 2015
@marcinant
Copy link
Contributor

Weird. AFAIK each project has to have an owner.
emacs-gitlab shouldn't die while owner name is empty. However I don't know how to duplicate this issue.
How can I remove user name?

@thomasf
Copy link
Author

thomasf commented May 29, 2015

I think it might be caused by projects only owned by groups instead of a user, ie. no project members, only group members. .. I can try to verify that if you cannot reproduce.

@marcinant
Copy link
Contributor

@thomasf Could you please confirm if #12 resolved this problem?

@thomasf
Copy link
Author

thomasf commented Jun 4, 2015

I'll verify soon, a bit busy atm.

@marcinant
Copy link
Contributor

Ok. Please, take a look at other changes and improvements merged recently, too.

@thomasf
Copy link
Author

thomasf commented Jun 11, 2015

I still get an error from gitlab-show-projects.. Will investigate at once.

@thomasf
Copy link
Author

thomasf commented Jun 11, 2015

This might be another issue, not sure.
The new error is caused by an (description) with a nil cdr in the data which makes (replace-regexp-in-string "\^M\\|\n" " " (assoc-default 'description p)) become evaluated as (replace-regexp-in-string(" \\|\n" " " nil) and the last nil argument causes an error.

Changing that line to (replace-regexp-in-string "\^M\\|\n" " " (or (assoc-default 'description p) "")) now lists all projects for me.. Actually it seems to list about half of the projects twice.

@marcinant
Copy link
Contributor

Ok. As I understand problem with list is when project has no description. I'll try to fix it soon.

@drym3r
Copy link
Contributor

drym3r commented Jul 10, 2017

Oh, I know see there's an issue for this. Fixed on drym3r@a3a9c35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants