We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In the readme it clearly states that there are three arguments sent to the secret option when it is defined as a function:
secret
this option can also be a function that takes the following parameters: (request, data, callback).
But the actual code only ever sends the request object and the callback:
if (typeof this.secret === 'function') { return this.secret(req, next); }
https://github.com/nlf/node-github-hook/blob/master/index.js#L278
The data is not available in that scope, as it's not passed to the getSecret method:
getSecret
self.getSecret(req, function (err, secret) {
https://github.com/nlf/node-github-hook/blob/master/index.js#L88
But it is clearly available at that time, as that method is called after req.on('end', ...).
req.on('end', ...)
The text was updated successfully, but these errors were encountered:
No branches or pull requests
In the readme it clearly states that there are three arguments sent to the
secret
option when it is defined as a function:But the actual code only ever sends the request object and the callback:
https://github.com/nlf/node-github-hook/blob/master/index.js#L278
The data is not available in that scope, as it's not passed to the
getSecret
method:https://github.com/nlf/node-github-hook/blob/master/index.js#L88
But it is clearly available at that time, as that method is called after
req.on('end', ...)
.The text was updated successfully, but these errors were encountered: