Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically Validate and/or Bump Version #121

Open
boyleconnor opened this issue Jun 25, 2021 · 1 comment
Open

Automatically Validate and/or Bump Version #121

boyleconnor opened this issue Jun 25, 2021 · 1 comment
Labels
Enhancement New feature or request Priority: Low

Comments

@boyleconnor
Copy link

Is your proposal related to a problem?

There is a tool version listed in both docker-compose.yml and tool_controller.py. When you release a version (which automatically gets Dockerized, thanks to our nifty ci.yml workflow), there is nothing to make sure that the version named in the tag matches the version listed in these files (it should!)

Describe the solution you'd like

If it is possible, it would be nice if the tag workflow could check that the version mentioned in the tag actually matches the version listed in these files.

It would also be nice if the tag workflow could automatically bump the version in these files after each release. E.g., after you release version 1.2.3, it automatically commits new versions of docker-compose.yml and tool_controller.py with 1.2.4 as the new version number. I think bumpversion does something like this.

@boyleconnor boyleconnor added the Enhancement New feature or request label Jun 25, 2021
@tschaffter
Copy link
Member

While I like the general idea for an internal project, we need to be mindful about introducing additional complexity and potentially unexpected automatic behavior - especially automatic commits - to the GH repositories of the example tools.

Also, there is no way to know that the next release version after 1.2.3 will be 1.2.4. It could as well be 1.3.0 or 2.0.0. How would you address this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Priority: Low
Projects
None yet
Development

No branches or pull requests

2 participants