You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is a tool version listed in both docker-compose.yml and tool_controller.py. When you release a version (which automatically gets Dockerized, thanks to our nifty ci.yml workflow), there is nothing to make sure that the version named in the tag matches the version listed in these files (it should!)
Describe the solution you'd like
If it is possible, it would be nice if the tag workflow could check that the version mentioned in the tag actually matches the version listed in these files.
It would also be nice if the tag workflow could automatically bump the version in these files after each release. E.g., after you release version 1.2.3, it automatically commits new versions of docker-compose.yml and tool_controller.py with 1.2.4 as the new version number. I think bumpversion does something like this.
The text was updated successfully, but these errors were encountered:
While I like the general idea for an internal project, we need to be mindful about introducing additional complexity and potentially unexpected automatic behavior - especially automatic commits - to the GH repositories of the example tools.
Also, there is no way to know that the next release version after 1.2.3 will be 1.2.4. It could as well be 1.3.0 or 2.0.0. How would you address this?
Is your proposal related to a problem?
There is a tool
version
listed in bothdocker-compose.yml
andtool_controller.py
. When you release a version (which automatically gets Dockerized, thanks to our niftyci.yml
workflow), there is nothing to make sure that the version named in the tag matches the version listed in these files (it should!)Describe the solution you'd like
If it is possible, it would be nice if the
tag
workflow could check that the version mentioned in the tag actually matches the version listed in these files.It would also be nice if the
tag
workflow could automatically bump the version in these files after each release. E.g., after you release version1.2.3
, it automatically commits new versions ofdocker-compose.yml
andtool_controller.py
with1.2.4
as the new version number. I thinkbumpversion
does something like this.The text was updated successfully, but these errors were encountered: