Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[public-1.13.2] VScript netprop reads are wrong #1427

Closed
dysphie opened this issue Apr 18, 2023 · 2 comments
Closed

[public-1.13.2] VScript netprop reads are wrong #1427

dysphie opened this issue Apr 18, 2023 · 2 comments
Assignees
Labels
Priority: Normal These issues should be fixed by the next release. Review before next release. Status: Completed Type: Code

Comments

@dysphie
Copy link
Collaborator

dysphie commented Apr 18, 2023

There appears to be a problem with NetProps reads in VScript, it's returning incorrect values and fetching data from the wrong offsets

Example:

image

local mins = NetProps.GetPropVector(cart, "m_vecMins");
local maxs = NetProps.GetPropVector(cart, "m_vecMaxs");

Msg(format("Mins: %.f %.f %.f \n", mins.x, mins.y, mins.z));
Msg(format("Maxs: %.f %.f %.f \n", maxs.x, maxs.y, maxs.z));

This outputs non-sense like:

image

where the maxs are actually m_vecOrigin

@felis-catus felis-catus added Status: Reviewed Type: Code Priority: Normal These issues should be fixed by the next release. Review before next release. labels Apr 18, 2023
@felis-catus
Copy link
Member

For reference, also bugged on Mapbase upstream: mapbase-source/source-sdk-2013#175

@felis-catus
Copy link
Member

Resolved by merging mapbase-source/source-sdk-2013#260, thank you @samisalreadytaken !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Normal These issues should be fixed by the next release. Review before next release. Status: Completed Type: Code
Development

No branches or pull requests

2 participants