From 5ca55e56478c5a5d4786906008d792c3ac749d16 Mon Sep 17 00:00:00 2001
From: Ugo Palatucci <upalatuc@redhat.com>
Date: Wed, 11 Sep 2024 10:18:01 +0200
Subject: [PATCH] CNV-48259: add flag for reference into other plugins

---
 .gitignore                                  |  3 ++-
 cypress/e2e/StatusList.spec.cy.ts           |  2 +-
 cypress/support/selectors.ts                |  2 +-
 plugin-manifest.ts                          | 19 +++++++++++++++----
 src/utils/flags/consts.ts                   |  1 +
 src/utils/flags/enableNMStateDynamicFlag.ts |  6 ++++++
 src/utils/flags/index.ts                    |  1 +
 7 files changed, 27 insertions(+), 7 deletions(-)
 create mode 100644 src/utils/flags/consts.ts
 create mode 100644 src/utils/flags/enableNMStateDynamicFlag.ts
 create mode 100644 src/utils/flags/index.ts

diff --git a/.gitignore b/.gitignore
index 244b9b05..027ba14c 100644
--- a/.gitignore
+++ b/.gitignore
@@ -108,4 +108,5 @@ cypress/screenshots
 
 ## Helm gitignore
 
-tmp/
\ No newline at end of file
+tmp/
+.DS_Store
\ No newline at end of file
diff --git a/cypress/e2e/StatusList.spec.cy.ts b/cypress/e2e/StatusList.spec.cy.ts
index c5a54287..c4acbffa 100644
--- a/cypress/e2e/StatusList.spec.cy.ts
+++ b/cypress/e2e/StatusList.spec.cy.ts
@@ -106,7 +106,7 @@ describe('NodeNetworkState list', () => {
       cy.get('table').should('contain', nns.metadata.name);
 
       // open filter toolbar
-      cy.get(ROW_FILTERS_BUTTON).click();
+      cy.get('button').contains('Filter').click();
 
       cy.get(LLDP_ENABLED_FILTER).check();
 
diff --git a/cypress/support/selectors.ts b/cypress/support/selectors.ts
index 1c4c5113..f58ddc62 100644
--- a/cypress/support/selectors.ts
+++ b/cypress/support/selectors.ts
@@ -3,7 +3,7 @@ export const EXPAND_INTERFACE_INFO = 'ethernet-expandable-section-toggle';
 export const INTERFACE_DRAWER_TEST_ID = 'interface-drawer';
 export const LLDP_DRAWER_DETAILS_SECTION_TEST_ID = 'lldp-section';
 
-export const ROW_FILTERS_BUTTON = 'button.pf-v5-c-select__toggle';
+export const ROW_FILTERS_BUTTON = 'button.pf-v5-c-menu-toggle';
 
 export const LLDP_ENABLED_FILTER = '#enabled[type="checkbox"]';
 
diff --git a/plugin-manifest.ts b/plugin-manifest.ts
index 079dd70b..0e7824ed 100644
--- a/plugin-manifest.ts
+++ b/plugin-manifest.ts
@@ -1,10 +1,11 @@
 import type { EncodedExtension } from '@openshift/dynamic-plugin-sdk';
-import type { ConsolePluginMetadata } from '@openshift-console/dynamic-plugin-sdk-webpack/lib/schema/plugin-package';
+import { FeatureFlag } from '@openshift-console/dynamic-plugin-sdk';
+import type { ConsolePluginBuildMetadata } from '@openshift-console/dynamic-plugin-sdk-webpack';
 
 import { PolicyExposedModules, PolicyExtensions } from './src/views/policies/manifest';
 import { StateExposedModules, StateExtensions } from './src/views/states/manifest';
 
-export const pluginMetadata = {
+export const pluginMetadata: ConsolePluginBuildMetadata = {
   name: 'nmstate-console-plugin',
   version: '0.0.1',
   displayName: 'OpenShift Console Plugin For NMState',
@@ -13,10 +14,20 @@ export const pluginMetadata = {
   exposedModules: {
     ...PolicyExposedModules,
     ...StateExposedModules,
+    nmstateFlags: './utils/flags',
   },
   dependencies: {
     '@console/pluginAPI': '*',
   },
-} as ConsolePluginMetadata;
+};
 
-export const extensions: EncodedExtension[] = [...PolicyExtensions, ...StateExtensions];
+export const extensions: EncodedExtension[] = [
+  {
+    properties: {
+      handler: { $codeRef: 'nmstateFlags.enableNMStateDynamicFlag' },
+    },
+    type: 'console.flag',
+  } as EncodedExtension<FeatureFlag>,
+  ...PolicyExtensions,
+  ...StateExtensions,
+];
diff --git a/src/utils/flags/consts.ts b/src/utils/flags/consts.ts
new file mode 100644
index 00000000..0c817671
--- /dev/null
+++ b/src/utils/flags/consts.ts
@@ -0,0 +1 @@
+export const FLAG_NMSTATE_DYNAMIC = 'NMSTATE_DYNAMIC';
diff --git a/src/utils/flags/enableNMStateDynamicFlag.ts b/src/utils/flags/enableNMStateDynamicFlag.ts
new file mode 100644
index 00000000..65a6399d
--- /dev/null
+++ b/src/utils/flags/enableNMStateDynamicFlag.ts
@@ -0,0 +1,6 @@
+import { SetFeatureFlag } from '@openshift-console/dynamic-plugin-sdk';
+
+import { FLAG_NMSTATE_DYNAMIC } from './consts';
+
+export const enableNMStateDynamicFlag = (setFeatureFlag: SetFeatureFlag) =>
+  setFeatureFlag(FLAG_NMSTATE_DYNAMIC, true);
diff --git a/src/utils/flags/index.ts b/src/utils/flags/index.ts
new file mode 100644
index 00000000..1740344b
--- /dev/null
+++ b/src/utils/flags/index.ts
@@ -0,0 +1 @@
+export { enableNMStateDynamicFlag } from './enableNMStateDynamicFlag';