Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to set rotation in the configuraion #18

Open
5 tasks
noah1510 opened this issue Dec 21, 2020 · 0 comments
Open
5 tasks

add option to set rotation in the configuraion #18

noah1510 opened this issue Dec 21, 2020 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@noah1510
Copy link
Owner

This feature should make things a lot easier.
It is an option for the controller_configuration to allow different rotation values.
This allows for a custom rotation in 90 degree steps to adjust to functions according to the actual layout of the segments.
moveRight will move the data right even if the matrix is rotated and the set functions will set the correct values.

This will require a lot of changes to the codebase and is not recommended for beginners unfamiliar with templates and the internal structure of the code.

  • add configuration option for the rotation (maybe even as an enum) and document what values have what meaning.
  • update the move functions to respect the rotation
  • update the set functions to respect the rotation
  • write example code for the use of this feature
  • add unit tests for this feature
@noah1510 noah1510 added enhancement New feature or request help wanted Extra attention is needed labels Dec 21, 2020
@noah1510 noah1510 added this to the v2.1.0 milestone Dec 21, 2020
@noah1510 noah1510 removed this from the v2.1.0 milestone Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant