Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for more display drivers #31

Open
3 tasks
noah1510 opened this issue Feb 19, 2021 · 1 comment
Open
3 tasks

Support for more display drivers #31

noah1510 opened this issue Feb 19, 2021 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@noah1510
Copy link
Owner

At the moment only MAX7219 and MAX7221 are expected to work correctly.
I the future all of the code in LedController_low_level.hpp should get refactored.

  • add a generic display_driver class which has information about the specific command, byte order, etc.
  • allow the controller_configuration to have an Instance of that class as option
  • use that config option to send commands in LedController_low_level.hpp

I don't know when this will be done but it might be a good issue if you want to get started contributing to open source projects.

@noah1510 noah1510 added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Feb 19, 2021
@noah1510
Copy link
Owner Author

469fae4 moved all of the opcodes and chartable into a separate class. This reduces the amount of #define statements and removes one public variable. It is also the groundwork for this issue.

@noah1510 noah1510 pinned this issue Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant