Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a more robust and versioned approach to compile flag setting. #787

Closed
monorimet opened this issue Jul 22, 2024 · 1 comment
Closed
Assignees

Comments

@monorimet
Copy link
Contributor

Right now, we handle compile flags in sd_inference/utils.py and pass in some combination of MLIR, keywords, device, IREE target, model name, etc. to compile a list of IREE compile flags to use.

This would be better managed by a repository of flag files, parametrized by pinned IREE "flag versions" (we move the SHA every time we need to update flags for a IREE-side change and just hardcode that SHA in utils.py, maybe) then by model, then by configuration (think the same configs we make unique .vmfb filenames for)

More on this later, but putting a bookmark here so it doesn't get lost.

@vivekkhandelwal1
Copy link
Contributor

Closed through #786

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants