Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use amd-smi in ROCmUtil #8

Open
smedegaard opened this issue Nov 12, 2024 · 0 comments
Open

use amd-smi in ROCmUtil #8

smedegaard opened this issue Nov 12, 2024 · 0 comments
Labels
enhancement New feature or request frontend Updates related to frontend

Comments

@smedegaard
Copy link
Collaborator

the problem

reportedly the rocm-smi is going to be replaced with the amd-smi . since the frontend code is currently expecting romc-smi to be install on the system, and calls it to get accelerator availability and metrics, it stands to reason that it will break if/when rocm-smi is deprecated

suggested solution

update serve.device.util.ROCmUtil to call amd-smi instead of rocm-smi.

definition of done

we have, at a minimum the same features as before the update

unit tests are passing

successfully run the updated torch serve on a machine with AMD accelerators, making sure we can run inference as before the update

@eppane eppane added frontend Updates related to frontend enhancement New feature or request labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Updates related to frontend
Projects
None yet
Development

No branches or pull requests

2 participants