Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dependancy on mongoose #92

Open
airtonix opened this issue May 7, 2014 · 1 comment
Open

remove dependancy on mongoose #92

airtonix opened this issue May 7, 2014 · 1 comment
Assignees
Milestone

Comments

@airtonix
Copy link

airtonix commented May 7, 2014

I'm not entirely familiar with mongodb, but surely JugglingDb can handle any interactions with mongodb?

The project advertises :

Bootstraped Admin GUI addon for mongoose, jugglingdb, or just as a form generator

Implying that one can integrate formage into their project without being required to install, interact or think about mongodb/mongoose.

However, this isn't true.

https://github.com/Empeeric/formage/blob/master/lib/index.js#L14-L24

  • throws errors if mongoose isn't installed

https://github.com/Empeeric/formage/blob/master/lib/index.js#L55-L56

  • undocumented required configuration to take advantage of jugglingdb instead of mongoose

https://github.com/Empeeric/formage/blob/master/lib/adapters/jugglingdb.js#L28

  • trying to load mongoose inside the jugglingdb adapter. throws error.

Perhaps I have misunderstood the direction Formage is taking, however from the README, it seems to me that I shoulnd't be required to install mongoose.

@refack
Copy link
Member

refack commented May 7, 2014

You are right, these are regressions from the main goal of being ORM agnostic (but there will be a dependency on there being an ORM with a declared schema).
P.S. If you can help me devise an automated test that will fail if there is an implicit dependency on mongoose, in a configuration where mongoose is installed (some require.cache of vm skulduggery)

@refack refack self-assigned this May 7, 2014
@refack refack added this to the 2.7.x milestone May 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants