Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Off-boarding Danielle Adams (@danielleadams) #1041

Closed
7 tasks done
RafaelGSS opened this issue Oct 11, 2024 · 6 comments
Closed
7 tasks done

Off-boarding Danielle Adams (@danielleadams) #1041

RafaelGSS opened this issue Oct 11, 2024 · 6 comments

Comments

@RafaelGSS
Copy link
Member

RafaelGSS commented Oct 11, 2024

The following steps should be taken as part of the offboarding process:

  • Be removed from the GitHub releasers team in the Node.js organizations.
  • Be removed from the GitHub security-release team in the Node.js and nodejs-private organizations.
  • Ensure their SSH key is removed from the dist user on the primary www server.
  • Move their GPG key in nodejs/node README.md to the 'Other keys used to sign some previous releases' section.
  • Open a PR in nodejs/docker-node to remove their GPG key from node.keys.
  • Ensure they are moved to 'Emeritus - Releasers team' in the nodejs/release README.
  • Remove them from the #nodejs-release-private team on the OpenJS Slack.

Refs: #1036

@RafaelGSS RafaelGSS changed the title Off-boarding Danielle Adams Off-boarding Danielle Adams (@danielleadams) Oct 11, 2024
@richardlau
Copy link
Member

See also nodejs/node#55381 re. moving to collaborator emeritus in the core repo.

@targos
Copy link
Member

targos commented Oct 14, 2024

Be removed from the GitHub releasers team in the Node.js organizations.

Is the plural form a typo or there really are more than one "Node.js organizations" ?

@richardlau
Copy link
Member

Be removed from the GitHub releasers team in the Node.js organizations.

Is the plural form a typo or there really are more than one "Node.js organizations" ?

I think the plural form is a typo. We don't have a releasers team anywhere other than nodejs, unlike the security-release team which exists in both nodejs and nodejs-private (on that note, maybe the checklist for security-release should be two checks (one per org)).

@richardlau
Copy link
Member

@RafaelGSS
Copy link
Member Author

Yeah, I've just copied and pasted from the governance section.

RafaelGSS added a commit to RafaelGSS/node that referenced this issue Oct 15, 2024
RafaelGSS added a commit to RafaelGSS/node that referenced this issue Oct 15, 2024
RafaelGSS added a commit to RafaelGSS/node that referenced this issue Oct 16, 2024
nodejs-github-bot pushed a commit to nodejs/node that referenced this issue Oct 17, 2024
Refs: nodejs/Release#1041
PR-URL: #55399
Refs: nodejs/Release#1036
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
aduh95 pushed a commit to nodejs/node that referenced this issue Oct 19, 2024
Refs: nodejs/Release#1041
PR-URL: #55399
Refs: nodejs/Release#1036
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
louwers pushed a commit to louwers/node that referenced this issue Nov 2, 2024
Refs: nodejs/Release#1041
PR-URL: nodejs#55399
Refs: nodejs/Release#1036
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@aduh95
Copy link
Contributor

aduh95 commented Nov 3, 2024

It looks like all the action items have been ticked off, closing as completed. Let's reopen if I missed something.

@aduh95 aduh95 closed this as completed Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants