Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure a minimum of 4GB of RAM on CI hosts? #3558

Closed
targos opened this issue Nov 4, 2023 · 6 comments
Closed

Ensure a minimum of 4GB of RAM on CI hosts? #3558

targos opened this issue Nov 4, 2023 · 6 comments

Comments

@targos
Copy link
Member

targos commented Nov 4, 2023

2GB is usually not enough to compile V8 and we have to restart CI jobs until they pass (thanks to ccache)

CleanShot 2023-11-04 at 17 18 55@2x

I'd like to upgrade the recent DO hosts that I created to 4GB instead of 2GB.

Another option could be to enable swap, but I suppose we prefer to avoid that if we can to avoid slowing down jobs?

Refs: #3557

@richardlau
Copy link
Member

2GB is usually not enough to compile V8 and we have to restart CI jobs until they pass (thanks to ccache)

👍 See also #3520.

Another option could be to enable swap, but I suppose we prefer to avoid that if we can to avoid slowing down jobs?

Avoiding swap would be preferable. I think the only thing to be watchful for would be increased costs (for the providers where we're using up credits). If we do add swap, I added a task to the bootstrap role to do so in #3522.

@targos
Copy link
Member Author

targos commented Nov 4, 2023

I think the only thing to be watchful for would be increased costs (for the providers where we're using up credits).

For DO, I'm going to open an issue soon. We have several machines that cost a lot and are underused or even unused

@richardlau
Copy link
Member

With the most recent V8 updates for Node.js 22 we've found that even 4GB is borderline and for many of the 4GB machines we've had to also add 2GB swap.
IIRC most of the providers scale memory with CPUs. We need to be careful if we also increase the number of CPUs as that may require even more memory if the build is compiling more things in parallel.

@mhdawson
Copy link
Member

I think moving up to 4G makes sense, agreed with @richardlau that we don't want to accidentally increase the parallelism which would defeat the goal of increasing the available memory.

@richardlau
Copy link
Member

I've just added 2GB of swap to the two DigitalOcean-hosted Ubuntu 22.04 x64 machines (#3877). They already had 4 GB of RAM and were failing due to the OOM killer. Builds on the IBM hosted machines were not failing -- those also have 4 GB of RAM but unlike DO, IBM provisioned them with 2 GB of swap on creation.

@targos
Copy link
Member Author

targos commented Sep 16, 2024

I'll close this. It seems that the right thing to do is add swap, not memory (because memory usually scales with CPUs)

@targos targos closed this as completed Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants