Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it work on Windows #63

Open
XhmikosR opened this issue Sep 27, 2019 · 2 comments
Open

Make it work on Windows #63

XhmikosR opened this issue Sep 27, 2019 · 2 comments

Comments

@XhmikosR
Copy link
Contributor

Not sure how much work will this be, but currently this doesn't work on Windows.

I'll add more info later.
@XhmikosR
Copy link
Contributor Author

XhmikosR commented Sep 27, 2019 •
edited
Loading

@rvagg it seems the failures on Windows are coming from gitexec. I have a WIP branch, which works but I'm not 100% sure it's safe.

So, perhaps, we could switch to something else like cross-spawn?

@XhmikosR XhmikosR mentioned this issue Oct 3, 2019
Merged
@rvagg rvagg mentioned this issue Oct 16, 2019
Closed
@DerekNonGeneric
Copy link

@XhmikosR, please let me know what the issue is on this.

I do have a Windows computer to test on at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

replace bash subcommands with separate shell spawns nodejs/changelog-maker
2 participants
@XhmikosR @DerekNonGeneric